-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the mean EnKF soil increment to the deterministic member #3295
base: develop
Are you sure you want to change the base?
Add the mean EnKF soil increment to the deterministic member #3295
Conversation
i) write out the ensemble mean reanalysis, and apply it to the deterministic member. ii) replace UFS_UTILS regridding of Gaussian soil analysis to model grid with an external ESMF-based program (with appropriate land masking) Requires: sorc/gsi_enkf.fd develop after Tue Nov 12. Latest works. sorc/gdas.cd/sorc/da-utils PR: NOAA-EMC/DA-utils#5 sorc/ufs_utils.fd from PR: ufs-community/UFS_UTILS#1010
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ShellCheck found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes looks good. seems like some checks are failing. I tried to recommend a couple updates that might help.
Co-authored-by: Cory Martin <[email protected]>
Co-authored-by: Cory Martin <[email protected]>
All:
|
Co-authored-by: Cory Martin <[email protected]>
Co-authored-by: Cory Martin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last comment, otherwise I think the changes look good (have not tested).
We should turn this on in one or more of the CI tests
I've added a CI test. |
All - I have one change I need to make tomorrow (staging the orog fix files), which will require a fortran change. Otherwise, I think everything else is done. Thanks for all your input! |
@CatherineThomas-NOAA noted yesterday that some more work is needed to finish this PR. |
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Quick update: the UFS_UTILS PR has been merged, and we're sorting out one last issue before updating the GDASApp hash. Once that's done, I'll update both hashes, and we should be good to merge. I checked with @CatherineThomas-NOAA, and she was referring to the two submodules that need updating. Note that running the soil analysis requires some additional fix files, and changing the modules for the two sfc update jobs. Do we want to add the new fix files within this PR? |
Description
Add mean EnKF soil increment to the deterministic member. Includes new regriding script and executable (in GDASApp) to perform masked bi-linear interpolation of the soil increments.
Resolves 2773
Type of change
Change characteristics
OUTDATED:
Exercizing the new soil analysis feature requires updating UFS_UTILS to at least commit e718003
UPDATE Feb 5:
After responding to reviews, requires updating to UFS_UTILS PR 1022
How has this been tested?
Tested on hera:
C96_atm3DVar, C96C48_hybatmaerosnowDA, and the default test ran succesfully.
Confirmed new functionality works as expected.
Confirmed that the commits do not change output from cycling the DA if the the new feature is not selected.
Checklist
NOTE: