Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HPSS via Globus #3240

Open
wants to merge 95 commits into
base: develop
Choose a base branch
from

Conversation

DavidHuber-NOAA
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA commented Jan 17, 2025

Description

This enables the archiving or ROTDIR tarballs to HPSS from systems that are not connected directly to HPSS as long as they can communicate to Niagara via Globus.

Transfers are initialized by the Sven client on Hercules or Orion and then finished on Niagara using the Doorman service. Documentation on these services can be found here: Sven User's Guide. These services were developed by George Fekete.

Resolves #1357

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? YES
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • Cycle test on Hercules
  • Forecast-only test on Hercules
  • Cycle test on Orion

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

github-advanced-security[bot]

This comment was marked as outdated.

@DavidHuber-NOAA
Copy link
Contributor Author

@DavidHuber-NOAA
Copy link
Contributor Author

I have finished a forecast-only test on Hercules. Additional work is required to enable this feature for ensembles, but it is mature enough for reviews. Thus marking this PR ready for review.

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of changes to review, just a few questions to start.

@DavidHuber-NOAA
Copy link
Contributor Author

Let's go ahead and move forward with this PR. I will add ensemble support in another PR.

Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test, no complaints from me. Thanks for adding this and addressing the minor comments I made earlier!

@DavidHuber-NOAA
Copy link
Contributor Author

This PR is ready to be reviewed again for technical aspects; documentation updates are still forthcoming.

Globus/HPSS testing completed successfully on Hercules for a C48_S2SW case.

I made one significant feature change that affects archiving options. The options HPSSARCH and LOCALARCH have been replaced with DO_ARCHTAR and ARCHTAR_TO. The first is either YES or NO and the second can be hpss, local, or globus_hpss.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will there be a need to archive the early-cycle enkf? if so, should this be JGLOBAL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the early-cycle is archivable as well. I will go ahead and make that change, but note that the ensembles are not currently being archived via globus -- that will be in a follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable transfers of archived data to Niagara from non-HPSS-connected systems
4 participants