-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen restriction on optional arguments in CCPP. #917
Open
dustinswales
wants to merge
18
commits into
NOAA-EMC:develop
Choose a base branch
from
dustinswales:feature/optional_args_again
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Loosen restriction on optional arguments in CCPP. #917
dustinswales
wants to merge
18
commits into
NOAA-EMC:develop
from
dustinswales:feature/optional_args_again
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture/optional_args_again
…ture/optional_args_again
…ture/optional_args_again
Open
15 tasks
…ture/optional_args_again
…ture/optional_args_again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When optional arguments were added back into the CCPP as part of #189, all variables that were conditionally allocated on the host side were required to be defined as
optional
within the schemes. This restriction required host-model logic to be implicitly built into the schemes and metadata. For example, scheme variables that wereoptional
in the context of the host model, but always required within the context scheme, still needed to be defined as optional within the scheme. This resulted in schemes having an arbitrary/confusing mis-match of required/optional arguments.This PR contains changes to the CCPP Framework (PR627) and CCPP Physics (PR248), reducing the restrictions on optional arguments and corresponding schemes changes, respectively. (There is also a small bugfix for the LW Jacobian used by RRTMGP).
Issue(s) addressed
N/A
Testing
RTs pass on Hera using Intel
(Running the full set now and will updated with links to RT logs when they complete)
Dependencies
N/A
Requirements before merging