Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upp with new variables capabilities #915

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

JesseMeng-NOAA
Copy link
Contributor

@JesseMeng-NOAA JesseMeng-NOAA commented Jan 24, 2025

Description

20250124 Jesse Meng and Wen Meng updated upp with new variables capabilities including snow-liquid-ratio, stream function, and velocity potential. This PR has been tested in upp regression tests with no baseline changes.

Issue(s) addressed

ufs-community/ufs-weather-model#2563
fv3atm #910

@JesseMeng-NOAA
@WenMeng-NOAA

including snow-liquid-ratio, stream function, and velocity potential.
@DusanJovic-NOAA DusanJovic-NOAA changed the title 20250124 Jesse Meng update upp with new variables capabilities Update upp with new variables capabilities Feb 7, 2025
@DusanJovic-NOAA
Copy link
Collaborator

@JesseMeng-NOAA I do not see the corresponding ufs-weather-model PR.

@WenMeng-NOAA
Copy link
Contributor

@DusanJovic-NOAA This PR only updates the upp hash. Could it be bundled with another fv3atm PR for the UFS update?

@JesseMeng-NOAA
Copy link
Contributor Author

@DusanJovic-NOAA This PR only updates the upp hash. Could it be bundled with another fv3atm PR for the UFS update?

@DusanJovic-NOAA As Wen mentioned, this only updates the upp hash in fv3atm. Let me know if you still want another ufs-weather-model PR.

@DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA This PR only updates the upp hash. Could it be bundled with another fv3atm PR for the UFS update?

@DusanJovic-NOAA As Wen mentioned, this only updates the upp hash in fv3atm. Let me know if you still want another ufs-weather-model PR.

Yes. Please open ufs-wm PR, code manages will need that in order to run regression tests. You will also need to run tests on Hera or Hercules and commit the log file.

@JesseMeng-NOAA
Copy link
Contributor Author

@DusanJovic-NOAA This PR only updates the upp hash. Could it be bundled with another fv3atm PR for the UFS update?

@DusanJovic-NOAA As Wen mentioned, this only updates the upp hash in fv3atm. Let me know if you still want another ufs-weather-model PR.

Yes. Please open ufs-wm PR, code manages will need that in order to run regression tests. You will also need to run tests on Hera or Hercules and commit the log file.

@DusanJovic-NOAA
A ufs-wm issue was opened and mentioned in this PR. But I am not sure how to open a ufs-wm PR on this. We don't have a branch to pull into ufs-wm until this fv3 PR is merged.

@JesseMeng-NOAA
Copy link
Contributor Author

@DusanJovic-NOAA This PR only updates the upp hash. Could it be bundled with another fv3atm PR for the UFS update?

@DusanJovic-NOAA As Wen mentioned, this only updates the upp hash in fv3atm. Let me know if you still want another ufs-weather-model PR.

Yes. Please open ufs-wm PR, code manages will need that in order to run regression tests. You will also need to run tests on Hera or Hercules and commit the log file.

ufs-wm PR opened ufs-community/ufs-weather-model#2599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants