Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor modification and bug fix in GFS cumulus convection schemes #885

Open
wants to merge 41 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
3ad9ff9
bug fix in using vertical transports of hydrometer variables
rhaesung Oct 25, 2024
8e1d798
add TKE at model layer interfaces (tkeh)
rhaesung Oct 25, 2024
c5aed69
update .gitmodules and ccpp/physics
rhaesung Oct 25, 2024
5849ac5
update GFS_typedefs.meta
rhaesung Oct 31, 2024
2f5213e
update physics
rhaesung Oct 31, 2024
816dce6
Merge remote-tracking branch 'upstream/develop' into conv_hr5update
rhaesung Nov 8, 2024
fd9e3b7
update FV3
rhaesung Nov 8, 2024
e72cafe
update ccpp
rhaesung Nov 20, 2024
0d53475
Merge remote-tracking branch 'upstream/develop' into conv_hr5update
rhaesung Nov 22, 2024
16903b9
update upp
rhaesung Nov 22, 2024
e4ac006
Update submodule pointer for ccpp-physics
rhaesung Nov 26, 2024
dd3d5e9
Update ccpp/physics with fixing the incorrectly modified precision co…
rhaesung Dec 9, 2024
3d8147d
update ccpp/physics
rhaesung Jan 13, 2025
ee5bf72
Merge remote-tracking branch 'upstream/develop' into conv_hr5update
rhaesung Jan 13, 2025
1912c71
update atmos_cubed_sphere
rhaesung Jan 13, 2025
680ced1
update framework
rhaesung Jan 13, 2025
5613701
update upp
rhaesung Jan 13, 2025
884046a
update ccpp/framework
rhaesung Jan 13, 2025
19d69c0
update ccpp/physics
rhaesung Jan 28, 2025
2340401
Merge remote-tracking branch 'upstream/develop' into conv_hr5update
rhaesung Jan 28, 2025
e7baf22
revert change to .gitmodules and update submodule pointers for ccpp-p…
rhaesung Feb 3, 2025
893691b
revert change to .gitmodules and update submodule pointers for ccpp-p…
rhaesung Feb 3, 2025
21dcef4
update .gitmodules
rhaesung Feb 3, 2025
91b41a9
update ccpp/physics
rhaesung Feb 4, 2025
c1ae5cc
Merge branch 'conv_hr5update' of https://github.com/rhaesung/fv3atm i…
rhaesung Feb 4, 2025
ff14036
update ccpp/physics
rhaesung Feb 5, 2025
cce0688
Merge branch 'conv_hr5update' of https://github.com/rhaesung/fv3atm i…
rhaesung Feb 5, 2025
7edd06a
Merge remote-tracking branch 'upstream/develop' into conv_hr5update
rhaesung Feb 5, 2025
4b02a49
update ccpp/physics
rhaesung Feb 10, 2025
9ce7818
update ccpp/physics
rhaesung Feb 13, 2025
1fb165e
update FV3
rhaesung Feb 14, 2025
a747051
update ccpp/physics
rhaesung Feb 14, 2025
a6009f7
update ccpp/physics
rhaesung Feb 14, 2025
e04d542
address reviewer comment
rhaesung Feb 14, 2025
92b37ff
update ccpp/physics
rhaesung Feb 14, 2025
fc72645
update ccpp/physics
rhaesung Feb 14, 2025
ebf9d92
update ccpp/physics
rhaesung Feb 18, 2025
b0a28f4
Merge remote-tracking branch 'upstream' into conv_hr5update
rhaesung Feb 18, 2025
131136f
update submodule pointer for atmos_cubed_sphere
rhaesung Feb 18, 2025
66d6940
update ccpp/physics
rhaesung Feb 21, 2025
fe6ec30
Merge remote-tracking branch 'upstream/develop' into conv_hr5update
rhaesung Feb 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@
branch = main
[submodule "ccpp/physics"]
path = ccpp/physics
url = https://github.com/ufs-community/ccpp-physics
branch = ufs/dev
# url = https://github.com/ufs-community/ccpp-physics
# branch = ufs/dev
url = https://github.com/rhaesung/ccpp-physics
branch = conv_hr5update
[submodule "upp"]
path = upp
url = https://github.com/NOAA-EMC/UPP
Expand Down
1 change: 1 addition & 0 deletions ccpp/data/CCPP_typedefs.F90
Original file line number Diff line number Diff line change
Expand Up @@ -1039,6 +1039,7 @@ subroutine gfs_interstitial_setup_tracers(Interstitial, Model)
do n=2,Model%ntrac
ltest = ( n /= Model%ntcw .and. n /= Model%ntiw .and. n /= Model%ntclamt .and. &
n /= Model%ntrw .and. n /= Model%ntsw .and. n /= Model%ntrnc .and. &
n /= Model%ntlnc .and. n /= Model%ntinc .and. &
n /= Model%ntsnc .and. n /= Model%ntgl .and. n /= Model%ntgnc .and. &
n /= Model%nthl .and. n /= Model%nthnc .and. n /= Model%ntgv .and. &
n /= Model%nthv .and. n /= Model%ntccn .and. n /= Model%ntccna .and. &
Expand Down
9 changes: 9 additions & 0 deletions ccpp/data/GFS_typedefs.F90
Original file line number Diff line number Diff line change
Expand Up @@ -1993,6 +1993,9 @@ module GFS_typedefs
real (kind=kind_phys), pointer :: tsnowpb(:) => null() !< accumulated surface snowfall in bucket (m)
real (kind=kind_phys), pointer :: rhonewsn1(:) => null() !< precipitation ice density outside RUC LSM (kg/m3)

!--- TKE used by convection schemes
real (kind=kind_phys), pointer :: tkeh(:,:) => null() !< vertical turbulent kinetic energy (m2/s2) at the model layer interfaces

!--- MYNN variables
real (kind=kind_phys), pointer :: edmf_a (:,:) => null() !
real (kind=kind_phys), pointer :: edmf_w (:,:) => null() !
Expand Down Expand Up @@ -7952,6 +7955,9 @@ subroutine diag_create (Diag, Model)
allocate (Diag%refl_10cm(IM,Model%levs))
allocate (Diag%max_hail_diam_sfc(IM))

!--- Vertical turbulent kinetic energy at model layer interfaces
allocate (Diag%tkeh(IM,Model%levs))

!--- New PBL Diagnostics
allocate (Diag%dkt(IM,Model%levs))
allocate (Diag%dku(IM,Model%levs))
Expand Down Expand Up @@ -8289,6 +8295,9 @@ subroutine diag_phys_zero (Diag, Model, linit, iauwindow_center)
!
!-----------------------------

! Vertical turbulent kinetic energy at modle layer interfaces
Diag%tkeh = zero

! Extra PBL diagnostics
Diag%dkt = zero
Diag%dku = zero
Expand Down
7 changes: 7 additions & 0 deletions ccpp/data/GFS_typedefs.meta
Original file line number Diff line number Diff line change
Expand Up @@ -9440,6 +9440,13 @@
dimensions = (horizontal_dimension)
type = real
kind = kind_phys
[tkeh]
standard_name = vertical_turbulent_kinetic_energy_at_interface
long_name = vertical turbulent kinetic energy at model layer interfaces
units = m2 s-2
dimensions = (horizontal_loop_extent,vertical_layer_dimension)
type = real
kind = kind_phys
[dkt]
standard_name = atmosphere_heat_diffusivity
long_name = atmospheric heat diffusivity
Expand Down