Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust observer yaml files for rrfs-workflow and downstream utilities #284

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

guoqing-noaa
Copy link
Collaborator

  • Use both short names and long names in the obs space.name. The short names are used as keywords in the downstream applications.
  • use short jdiag file names to match rrfs-workflow (downstream applications will also look for short jdiag file names)
  • TODO: @OBSFILE@ needs to be replaced with prescribed ioda file names, such as data/obs/ioda_aircar.nc, etc. rrfs-workflow will avoid unnecessary string replacement. But this may affect the ctest, so I will leave this unchanged until a separate new PR.

@delippi
Copy link
Collaborator

delippi commented Feb 18, 2025

  • I can probably live with the short and long names for obs space, but can you help me understand the exact use case for this? Is it just for the yaml parsing tools and to not have to type the long name fully? Why does one need to use those yaml tools in the first place? What information are you trying to get from those tools that you couldn't get (probably easier) by opening up the file?

  • What downstream applications are going to be looking for the short jdiag file names? Couldn't they just use the names as they are now? All of my scripts right now assume the jdiag has the same name convention as the jedi yaml itself (e.g., jdiag_${yamlname}.nc4). I find that much easier. Plus, I feel more verbose names is the way of the JEDI and is just more descriptive for all users.

  • What is the NCO standard for the observation file names? I was thinking they needed to have a date string appended to the filename. If that is the case, we would need to keep the @OBSFILE@ placeholder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants