Add delete_bins to C API #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
felixhekhorn
left a comment
felixhekhorn
left a comment
There was a problem hiding this comment.
some small comments
Contributor
|
LGTM, feel free to merge it. |
Member
Radonirinaunimi
left a comment
Radonirinaunimi
left a comment
There was a problem hiding this comment.
Thanks @peterkrack for this! Before merging, could you please add a test for this?
PS: The formatting also seems off (although this could be taken care of by the pre-commit hooks).
Contributor
Author
|
I modified the advanced_filling example to include a call to this function. I can also write a separate test if needed. |
Radonirinaunimi
approved these changes
Nov 17, 2025
Member
That is more than enough, thanks a lot! Please feel free top merge once the tests are done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need this function in the C API.