Skip to content

Commit

Permalink
DI-5385 Fix button display in non-develop mode
Browse files Browse the repository at this point in the history
  • Loading branch information
marcinca committed May 23, 2023
1 parent dcaa162 commit b46baea
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
7 changes: 0 additions & 7 deletions classes/output/core_renderer.php
Original file line number Diff line number Diff line change
Expand Up @@ -166,13 +166,6 @@ public function render_login(\core_auth\output\login $form) {
$context->login_header_text_default = get_config( 'theme_nhse', 'login_header_text_default');
$context->login_header_text = get_config( 'theme_nhse', 'login_header_text');

// Preview SSO login for in DEBUG_DEVELOPER mode regardless identity provider config
if ($CFG->debug < DEBUG_DEVELOPER) {
$context->hasidentityproviders = true;
$context->identityproviders = true;
$context->cansignup = true;
}

return $this->render_from_template('core/loginform', $context);
}

Expand Down
6 changes: 3 additions & 3 deletions templates/core/loginform.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
{{#identityproviders}}
<div class="potentialidp">
<a href="{{url}}"
class="nhsuk-button nhsuk-u-margin-bottom-0"
class="nhsuk-button nhsuk-u-margin-bottom-2"
title={{#quote}}{{#str}} login_oauth_with, theme_nhse {{/str}} {{name}}{{/quote}}>
<!-- we add a setting here because Moodle auto picks icon up from the provider if OAuth setting doesnt specify one -->
{{#oauth_login_button_icon}}
Expand Down Expand Up @@ -260,8 +260,8 @@
</div>
</div>
</div>
<div class="nhsuk-form-group nhsuk-u-margin-bottom-0">
<button type="submit" class="nhsuk-button nhsuk-u-margin-bottom-0" id="loginbtn">Login</button>
<div class="nhsuk-form-group nhsuk-u-margin-bottom-1">
<button type="submit" class="nhsuk-button nhsuk-u-margin-bottom-2" id="loginbtn">Login</button>
</div>
</form>

Expand Down

0 comments on commit b46baea

Please sign in to comment.