Allow consumers to disable fieldset rendering for single inputs #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakeb-nhs
force-pushed
the
prevent-fieldset-render-for-single-inputs
branch
from
ec1d3cf to
ab1d9c4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During an accessibility review for our Child BMI tool, it was raised that we wrap all our inputs in
fieldsetelements even if there is only a single one. This is incorrect/dubious because fieldsets are semantically used to group related inputs together, and if there is only one there is no need for a fieldset to be used.From a screen reader point of view. they announce fieldsets as a group. i.e. a group of input fields, so a user might expect there to be more than 1. This could cause confusion and is extra audio clutter.
Guidance on this in the NHS service manual is light, but reading the page on Fieldset suggests it is only to be used when grouping multiple inputs.
Now, when using the
Fieldsetcomponent, there is a prop that consumers can use to control this behaviour. If settingdisableFieldsetRenderWithSingleFormElementstotrue, thefieldsetelement within thenhsuk-form-groupwrapper will not be rendered if the group contains only a single input. The default for this prop isfalse, meaning no change to current behaviour.