Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix care card css classes #194

Closed
wants to merge 1 commit into from

Conversation

Spencerooni
Copy link

I was using this library and couldn't understand why the care card component wasn't working. Upon investigation, I discovered that the css classes being applied are incorrect. They must have been updated at some point.

https://service-manual.nhs.uk/design-system/patterns/help-users-decide-when-and-where-to-get-care

I think I've got them all...

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KaiSpencer
Copy link
Contributor

Hi @Spencerooni
Thanks for raising this, whilst this is the correct implementation for how the css classes should be, we are currently still on nhsuk-frontend v5

The changes you have are correct for the braking changes in nhsuk-frontend@6 which we have a WIP PR #189.

The reason as to why you are seeing the care card not working is that we have a bug where our peerDependency range allows you to install too high a version of the frontend which then has classnames that do-not match.

We have an issue for this #179

As a workaround, you can downgrade your version of the nhsuk-frontend to ^5 whilst we work on upgrading internally to support upto v8.

@Tomdango can we look at getting #179 Merged, as this has cropped up a few times now.

@Spencerooni
Copy link
Author

Ah, no problem. I'll downgrade my nhsuk-frontend and close this. Thank you for the quick response.

@Spencerooni Spencerooni deleted the fix-carecard branch January 23, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants