add width and height the NHS logo as per the core library #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NHS logo was missing a width and height attribute causing some validation issues. https://nhs-service-manual.slack.com/archives/CDJ29AQCD/p1686240007585369
KaiSpencer
approved these changes
Jun 8, 2023
marynicholson3
approved these changes
Jun 9, 2023
|
Hi both - Developers on my team have gotten back to me with some additional validation issues with this. This is the message I've received from them:
This slack thread has a screenshot of the the validation errors being received |
|
The |
|
@Tomdango I don't have merging permissions, could you take a look and do the thing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NHS logo was missing a width and height attribute causing some validation issues.
There also seems to be a few extra attributes that might not be needed - but will leave for now. See the markup at: https://service-manual.nhs.uk/design-system/components/header
https://nhs-service-manual.slack.com/archives/CDJ29AQCD/p1686240007585369