Skip to content

PEAR-2695 - Redundant survival API calls?#1734

Open
amlehman wants to merge 10 commits into
developfrom
PEAR-2695-redundant-survival
Open

PEAR-2695 - Redundant survival API calls?#1734
amlehman wants to merge 10 commits into
developfrom
PEAR-2695-redundant-survival

Conversation

@amlehman

Copy link
Copy Markdown
Contributor

Description

  • Skips survival call when comparativeSurvival is undefined
  • Moves the filter logic that was all over into its own hook
  • Rearranged hooks so that have a clearer purpose and single responsibility
  • Streamlined some logic

Checklist

  • Added proper unit tests
  • Left proper TODO messages for any remaining tasks
  • Scanned for web accessibility with aXe, and mitigated or documented
    flagged issues

Screenshots/Screen Recordings (if Appropriate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants