Skip to content

Add Aerosol and Cloud Chemistry Options#842

Draft
mattldawson wants to merge 22 commits intomainfrom
develop-add-miam
Draft

Add Aerosol and Cloud Chemistry Options#842
mattldawson wants to merge 22 commits intomainfrom
develop-add-miam

Conversation

@mattldawson
Copy link
Copy Markdown
Collaborator

This PR adds MIAM to the MUSICA library, and makes its components available via the Python API.

Three new tutorial chapters are included (DAE solvers, MIAM components, CAM cloud chemsitry)

This is in draft as dependency PRs are finalized and merged.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 90.04425% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.83%. Comparing base (c7e3663) to head (59b95bf).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/miam/miam_builder.cpp 88.08% 23 Missing ⚠️
python/musica/miam/model.py 86.66% 8 Missing ⚠️
python/musica/mechanism_configuration/species.py 78.94% 4 Missing ⚠️
src/micm/micm.cpp 63.63% 4 Missing ⚠️
src/micm/cpu_solver.cpp 89.28% 3 Missing ⚠️
src/micm/micm_c_interface.cpp 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
+ Coverage   74.15%   74.83%   +0.68%     
==========================================
  Files         127      135       +8     
  Lines       10089    10536     +447     
==========================================
+ Hits         7481     7885     +404     
- Misses       2608     2651      +43     
Flag Coverage Δ
cpp_fortran 66.72% <86.90%> (+1.01%) ⬆️
javascript 93.22% <ø> (ø)
python 79.92% <94.00%> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@K20shores
Copy link
Copy Markdown
Collaborator

@mattldawson how easy is it to update the liquid water content throughout a simulation?

@mattldawson
Copy link
Copy Markdown
Collaborator Author

@mattldawson how easy is it to update the liquid water content throughout a simulation?

Cloud liquid water content, in MICM/MIAM, would typically just be a condensed-species named water or H2O or something. It's just like any other solver variable, it will be adjusted based on processes that form or remove it. It could also be an algebraic variable that's calculated from a constraint. But, there's nothing special about it - it's just another condensed-phase species.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants