perf(client): smoother chat scrolling with wider list cache#1116
Open
NC1107 wants to merge 1 commit into
Open
Conversation
…shing The chat ListView used Flutter's default cacheExtent of 250px, which is too tight for messages that include images, reactions, and reply quotes — each takes a frame to lay out, so momentum scrolling on long histories briefly showed blank space before items mounted. Bumped to 600px (about one viewport) so the visible window stays warm during fast scrolling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The chat `ListView.builder` had no explicit `cacheExtent`, defaulting to 250px. For messages that include images, reactions, and reply quotes — each requiring a frame to lay out — momentum scrolling occasionally flashed blank space before items mounted. Bump to 600px (about one viewport) so the visible window stays warm during fast scrolling.
Test plan
Behind the scenes
Single-line change in `chat_message_list.dart`. No behaviour change, only smoother scrolling.