refactor(client): cut cognitive complexity in chat panel body wrapper#1115
Open
NC1107 wants to merge 1 commit into
Open
refactor(client): cut cognitive complexity in chat panel body wrapper#1115NC1107 wants to merge 1 commit into
NC1107 wants to merge 1 commit into
Conversation
buildChatContentBox sat at S3776 cognitive complexity 16 (budget 15) because it computed both useColumn and useColumnDrawer inline AND branched on them again at the bottom to wrap the chatArea. Pulled the layout decision into a small _ColumnLayoutDecision data class + _resolveColumnLayout helper, and the 3-way wrapping into _wrapForColumnLayout. The top function is now a flat linear sequence well under the budget; no behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`buildChatContentBox` sat at S3776 cognitive complexity 16 (budget 15). The top function computed both `useColumn` and `useColumnDrawer` inline AND branched on them again at the bottom to wrap the chatArea. Now it's a flat linear sequence: layout decision → build chatArea → wrap. No behaviour change.
Behind the scenes
Test plan
References #1104.