refactor(client): cut cognitive complexity in narrow chat-panel orchestrator#1112
Open
NC1107 wants to merge 1 commit into
Open
refactor(client): cut cognitive complexity in narrow chat-panel orchestrator#1112NC1107 wants to merge 1 commit into
NC1107 wants to merge 1 commit into
Conversation
…lpers _buildNarrowChatPanel had cognitive complexity ~25 from inline GestureDetector callbacks with nested ternaries and an inline lounge-shell early-return. Extracted helpers: - _buildLoungeShell — reused at both narrow-layout entry points (was duplicated) - _buildNarrowChatContent — ChatPanel composition with the right callbacks - _selectConversationFromDrawer — the column-drawer pick-conversation closure - _buildEdgeSwipeGestureWrapper — wraps the gesture detector or returns child verbatim - _handleSwipeStart / _handleSwipeUpdate / _handleSwipeEnd — the 3 callbacks - _buildEdgeSwipePeek — the left-edge peek overlay No behaviour change; all 724 widget tests still pass. Clears one of the four S3776 hotspots flagged in the 2026-05-22 SonarQube baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`_buildNarrowChatPanel` was a ~155-line method with nested GestureDetector callbacks, inline ternaries, and a duplicated lounge-shell early-return — SonarQube flagged it as one of the four remaining S3776 hotspots (CC≈25, budget=15). This PR splits it into seven small helpers; each is well under the budget, no behaviour change.
Behind the scenes
Test plan
References #1104.