refactor(client): SettingsListTile widget to dedupe settings-row pattern#1110
Open
NC1107 wants to merge 1 commit into
Open
refactor(client): SettingsListTile widget to dedupe settings-row pattern#1110NC1107 wants to merge 1 commit into
NC1107 wants to merge 1 commit into
Conversation
Centralises the standard settings-row shape (icon + title + optional subtitle + chevron-or-custom-trailing) so each section stops re-declaring contentPadding: EdgeInsets.zero, the muted-icon size, theme-aware text styles, and the chevron trailing. Migrates 4 sites in about_section and 1 in data_storage_section. Other callsites with bespoke trailing widgets or stack-based leading remain untouched for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds `SettingsListTile` — a thin wrapper over Material's `ListTile` that bakes in the standard settings-row defaults (`contentPadding: EdgeInsets.zero`, muted icon at size 22, theme-aware title and subtitle text, and a chevron trailing when `onTap` is set). Migrates 5 of the highest-impact call sites in `about_section.dart` and `data_storage_section.dart`.
Test plan
Why this and not the existing CardRow?
`CardRow` is the badge-style row used by the Settings home list (colored icon badge, no subtitle). `SettingsListTile` is the plainer settings-detail row (no badge, with subtitle line). Different visual treatment, complementary widgets.
Behind the scenes
Continues the 2026-05-22 componentization pass (#1098).