refactor(client): split ChatMessage.fromJson into typed helpers#1107
Open
NC1107 wants to merge 1 commit into
Open
refactor(client): split ChatMessage.fromJson into typed helpers#1107NC1107 wants to merge 1 commit into
NC1107 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears SonarQube S3776 at
chat_message.dart:165(was CC=27) by breaking the system-event sentinel translator into four single-purpose static helpers. Each branch of the orchestrator now reads as a one-line dispatch.Behind the scenes
translateSystemSentinelis now a flat dispatcher over the four known event tags; cognitive complexity drops to 4 (≤ 15 budget)._parseUuidUsernameto parse the<uuid>:<username>payload that every event tag shares._formatActiveEventfor "X joined" / "X left" style strings (first-person "You joined")._formatPassiveEventfor "X was removed" / "X was banned" style strings (first-person "You were removed")._subjectForto centralise the self-vs-peer subject phrase rendering used by both active and passive events.ChatMessage.fromServerJson, theChatMessageconstructor, and the JSON wire shape are untouched.Tests: all 86 model +
chat_provider_state_testcases pass (test/models/chat_message_test.dart,test/models/chat_message_extended_test.dart,test/providers/chat_provider_state_test.dart).dart formatandflutter analyze --fatal-infosclean.