refactor(client): extract upload client content-type constants#1097
Open
NC1107 wants to merge 1 commit into
Open
refactor(client): extract upload client content-type constants#1097NC1107 wants to merge 1 commit into
NC1107 wants to merge 1 commit into
Conversation
…ient Clears two SonarQube S1192 duplications by lifting Content-Type, application/json, and application/octet-stream into file-scope const strings.
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
application/octet-stream,application/json, andContent-Typeinto file-scope const strings inchunked_upload_client.dart— clears two SonarQube S1192 duplication issues that were the only CRITICAL items open in that file.Test plan
flutter analyzeclean on the touched fileBehind the scenes only — no behaviour change.