Skip to content

Conversation

@jsignell
Copy link
Collaborator

Closes #43

Adds a section to the notebook to capture the env vars as well.

@jsignell jsignell requested a review from wildintellect August 20, 2025 18:56
@wildintellect wildintellect requested review from batpad and sunu August 20, 2025 19:07
@wildintellect
Copy link
Contributor

This makes sense, hoping @batpad or @sunu can chime in if there's a reason not to do this. conda should be using mamba solver so build speed shouldn't change.

@batpad
Copy link
Collaborator

batpad commented Aug 21, 2025

Looks like the build ran fine, so this seems fine to me. Will wait for @sunu to give a final 👍 - @wildintellect is this something we want to roll-out soon?

Copy link
Member

@sunu sunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! The new environment variable checks in the notebook test are passing too.
Thanks so much, @jsignell!

@wildintellect
Copy link
Contributor

@batpad we're going to also include #42 and then yes we'd like to deploy it next sprint (next week) after some light testing.

@jsignell jsignell merged commit 5a56c7c into main Aug 21, 2025
1 check passed
@jsignell jsignell deleted the env-vars branch August 21, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENV Variables from Conda environment yaml are missing

5 participants