Release Branch for 5.4.0 #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gins to test that
|
@jvigliotta , if this doesn't close #317 , we shouldn't say it does |
davetsay
requested changes
Oct 1, 2025
…move special handling for installing summary widgets
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
davetsay
approved these changes
Oct 2, 2025
| const pluginExists = openmct.plugins[plugin] || openmct.plugins.example[plugin]; | ||
| const examplePluginExists = openmct.plugins.example[plugin]; | ||
| const pluginExists = openmct.plugins[plugin] || examplePluginExists; | ||
| const pluginEnabled = pluginConfig?.enabled; |
There was a problem hiding this comment.
should we follow the previous format summary widgets followed, or just require an enabled flag now?
config.plugins.summaryWidgets === true ||
config.plugins.summaryWidgets?.enabled === true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #348
closes #208
closes #336
closes #209
This is a larger merge of the following items (in addition to various fixes for parity with latest Open MCT):