Fix 'Send to Workspace' to work with new Sequencing Workspaces #1809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephVolosin
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
requested changes
Oct 21, 2025
| const dispatch = createEventDispatcher<{ | ||
| close: void; | ||
| save: { parcelId: number; workspaceId: number }; | ||
| save: { workspaceId: number; workspaceName: string }; |
Collaborator
There was a problem hiding this comment.
Do you need to pass the workspace name in this save event? It doesn't look like you're using it. I think ideally, the workspaceId should be enough.
duranb
requested changes
Oct 28, 2025
Collaborator
duranb
left a comment
duranb
left a comment
There was a problem hiding this comment.
Do you also mind adding permission checks to the workspace dropdown or submit button for if the user even has access to the workspace that they want to send the sequence to? There is a featurePermission.workspace() in utilities/permissions.ts that you can use to see if the user can upload to the selected workspace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request updates the 'Send to Workspace' feature in plan expansion to let the user create a new file in a sequencing workspace loaded with the expansion result of an expanded sequence.
Screen.Recording.2025-10-16.at.11.17.30.AM.mov