Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter grid CanAdd MyObjectBuilder_CubeBlock blocks check #117

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

OwendB1
Copy link

@OwendB1 OwendB1 commented Oct 30, 2024

Reason for this change is that Quantum hangar spawns a grid in with original authorship in tact. Altered check now loops through the owners of all available blocks in the list and then checks each block against its rightful author's limits.

Copy link
Author

@OwendB1 OwendB1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes checked and tested

@OwendB1
Copy link
Author

OwendB1 commented Nov 2, 2024

@viktor-ferenczi Could you approve this please?

@viktor-ferenczi
Copy link
Contributor

You can try to add me as a reviewer. I do not have the access rights to approve/merge PRs in this repository.

@OwendB1
Copy link
Author

OwendB1 commented Nov 2, 2024

Thats unfortunate, I also cant

@OwendB1
Copy link
Author

OwendB1 commented Nov 2, 2024

@N1Ran Could you review this ASAP please? :)

@OwendB1
Copy link
Author

OwendB1 commented Dec 21, 2024

@N1Ran PR is still open, need this to fix quantum hangar check functionality!

Copy link
Owner

@N1Ran N1Ran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR no longer valid and will need re-submission for review

@OwendB1 OwendB1 requested a review from N1Ran December 21, 2024 16:16
Copy link
Owner

@N1Ran N1Ran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the commented changes and I can push

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this from the PR

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this from the PR

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove from PR

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove from PR

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the setup.bat also

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't had the time, will do tomorrow

@OwendB1 OwendB1 requested a review from N1Ran December 22, 2024 12:20
Copy link
Author

@OwendB1 OwendB1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes were made according to what you wanted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants