Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite FileSystemInfo #485

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
279dc22
filesysteminfo: eliminate MACROs to improve readability
ulmus-scott Nov 14, 2022
ef0519d
use FileSystemInfo instead of getDiskSpace()
ulmus-scott Nov 14, 2022
725ae15
StorageGroup::FindNextDirMostFree(): C++ modernization
ulmus-scott Jan 25, 2022
bc0aa1e
filesysteminfo: '#include's cleanup
ulmus-scott Jan 26, 2022
f7f8803
filesysteminfo: continue rewrite
ulmus-scott Jan 26, 2022
98e08c8
filesysteminfo: pass by value and std::move
ulmus-scott Jan 26, 2022
ec1b6d3
filesysteminfo.h: spaces and comment
ulmus-scott Jan 26, 2022
437536a
filesysteminfo.h: C++ does not require a void parameter
ulmus-scott Jan 26, 2022
843e5e1
mytharchivehelper/main.cpp: use FileSystemInfo
ulmus-scott Feb 16, 2022
7de1099
mythbackend/playbacksock: add TODOs
ulmus-scott Feb 22, 2022
9097306
create namespace FileSystemInfoManager
ulmus-scott Nov 14, 2022
aab6171
use FileSystemInfo::Consolidate()
ulmus-scott Feb 22, 2022
c08a851
use FileSystemInfoManager::ToStringList()
ulmus-scott Feb 22, 2022
d6a4ceb
use FileSystemInfo::ToStringList()
ulmus-scott Feb 22, 2022
30e637d
mythbackend: finish FileSystemInfoList conversion
ulmus-scott Mar 7, 2022
d1d4d48
mythfrontend: finish FileSystemInfoList conversion
ulmus-scott Mar 7, 2022
0c2e574
filesysteminfo: move Consolidate() into FileSystemInfoManager
ulmus-scott Mar 7, 2022
f83469e
filesysteminfo: rename RemoteGetInfo to FileSystemInfoManager::GetInf…
ulmus-scott Mar 7, 2022
0b35f4d
filesysteminfo: convert FileSystemInfoList to QVector
ulmus-scott Mar 7, 2022
9dfcff8
MainServer::GetFilesystemInfos(): use FileSystemInfoManager::FromStri…
ulmus-scott Mar 7, 2022
7442efd
filesysteminfo.cpp: move functions together
ulmus-scott Mar 8, 2022
9018fa2
bump MYTH_BINARY_VERSION
ulmus-scott Nov 14, 2022
3ccb82e
FileSystemInfo::refresh(): use QStorageInfo
ulmus-scott Jun 18, 2024
18edcf9
FileSystemInfo: remove unused set functions
ulmus-scott Jun 22, 2024
fc93c7d
libmythbase/storagegroup.cpp: reduce scope of variable and eliminate …
ulmus-scott Nov 17, 2024
c1fbbe8
FileServerHandler::HandleQueryFreeSpace(): use FileSystemInfoManager
ulmus-scott Nov 17, 2024
3a95702
move generation of totals into FileSystemInfoManager::Consolidate()
ulmus-scott Nov 17, 2024
b64dbce
use FileServerHandler::QueryFileSystems() in mythbackend/mainserver.cpp
ulmus-scott Nov 17, 2024
f2390bc
make PlaybackSock::GetDiskSpace() return a FileSystemInfoList
ulmus-scott Nov 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
mythbackend: finish FileSystemInfoList conversion
ulmus-scott committed Mar 1, 2025
commit 30e637d9b6a0042e955a0935bdc6a44f6ca57cde
12 changes: 6 additions & 6 deletions mythtv/programs/mythbackend/autoexpire.cpp
Original file line number Diff line number Diff line change
@@ -125,7 +125,7 @@ void AutoExpire::CalcParams()
{
LOG(VB_FILE, LOG_INFO, LOC + "CalcParams()");

QList<FileSystemInfo> fsInfos;
FileSystemInfoList fsInfos;

m_instanceLock.lock();
if (m_mainServer)
@@ -168,7 +168,7 @@ void AutoExpire::CalcParams()
}
m_instanceLock.unlock();

QList<FileSystemInfo>::iterator fsit;
FileSystemInfoList::iterator fsit;
for (fsit = fsInfos.begin(); fsit != fsInfos.end(); ++fsit)
{
if (fsMap.contains(fsit->getFSysID()))
@@ -406,8 +406,8 @@ void AutoExpire::ExpireRecordings(void)
{
pginfolist_t expireList;
pginfolist_t deleteList;
QList<FileSystemInfo> fsInfos;
QList<FileSystemInfo>::iterator fsit;
FileSystemInfoList fsInfos;
FileSystemInfoList::iterator fsit;

LOG(VB_FILE, LOG_INFO, LOC + "ExpireRecordings()");

@@ -481,7 +481,7 @@ void AutoExpire::ExpireRecordings(void)
.arg(fsit->getFSysID()));
LOG(VB_FILE, LOG_INFO, QString("Directories on filesystem ID %1:")
.arg(fsit->getFSysID()));
QList<FileSystemInfo>::iterator fsit2;
FileSystemInfoList::iterator fsit2;
for (fsit2 = fsInfos.begin(); fsit2 != fsInfos.end(); ++fsit2)
{
if (fsit2->getFSysID() == fsit->getFSysID())
@@ -512,7 +512,7 @@ void AutoExpire::ExpireRecordings(void)
.arg(m_desiredSpace[fsit->getFSysID()] / 1024));

QMap<QString, int> dirList;
QList<FileSystemInfo>::iterator fsit2;
FileSystemInfoList::iterator fsit2;

LOG(VB_FILE, LOG_INFO,
QString(" Directories on filesystem ID %1:")
1 change: 0 additions & 1 deletion mythtv/programs/mythbackend/autoexpire.h
Original file line number Diff line number Diff line change
@@ -18,7 +18,6 @@

class ProgramInfo;
class EncoderLink;
class FileSystemInfo;
class MainServer;

using pginfolist_t = std::vector<ProgramInfo*>;
6 changes: 3 additions & 3 deletions mythtv/programs/mythbackend/mainserver.cpp
Original file line number Diff line number Diff line change
@@ -312,7 +312,7 @@ MainServer::MainServer(bool master, int port,
{
// Make sure we have a good, fsinfo cache before setting
// mainServer in the scheduler.
QList<FileSystemInfo> m_fsInfos;
FileSystemInfoList m_fsInfos;
GetFilesystemInfos(m_fsInfos, false);
sched->SetMainServer(this);
}
@@ -5252,7 +5252,7 @@ void MainServer::BackendQueryDiskSpace(QStringList &strlist, bool consolidated,
}
}

void MainServer::GetFilesystemInfos(QList<FileSystemInfo> &fsInfos,
void MainServer::GetFilesystemInfos(FileSystemInfoList &fsInfos,
bool useCache)
{
// Return cached information if requested.
@@ -5294,7 +5294,7 @@ void MainServer::GetFilesystemInfos(QList<FileSystemInfo> &fsInfos,

FileSystemInfo::Consolidate(fsInfos, false, maxWriteFiveSec);

QList<FileSystemInfo>::iterator it1;
FileSystemInfoList::iterator it1;
if (VERBOSE_LEVEL_CHECK(VB_FILE | VB_SCHEDULE, LOG_INFO))
{
LOG(VB_FILE | VB_SCHEDULE, LOG_INFO, LOC +
6 changes: 3 additions & 3 deletions mythtv/programs/mythbackend/mainserver.h
Original file line number Diff line number Diff line change
@@ -15,6 +15,7 @@

// MythTV headers
#include "libmythbase/exitcodes.h"
#include "libmythbase/filesysteminfo.h"
#include "libmythbase/mthreadpool.h"
#include "libmythbase/mythdeque.h"
#include "libmythbase/mythdownloadmanager.h"
@@ -36,7 +37,6 @@
class QUrl;
class MythServer;
class QTimer;
class FileSystemInfo;
class MetadataFactory;
class FreeSpaceUpdater;

@@ -146,7 +146,7 @@ class MainServer : public QObject, public MythSocketCBs
size_t GetCurrentMaxBitrate(void);
void BackendQueryDiskSpace(QStringList &strlist, bool consolidated,
bool allHosts);
void GetFilesystemInfos(QList<FileSystemInfo> &fsInfos,
void GetFilesystemInfos(FileSystemInfoList &fsInfos,
bool useCache=true);

int GetExitCode() const { return m_exitCode; }
@@ -351,7 +351,7 @@ class MainServer : public QObject, public MythSocketCBs
QTimer *m_autoexpireUpdateTimer {nullptr}; // audited ref #5318
static QMutex s_truncate_and_close_lock;

QList<FileSystemInfo> m_fsInfosCache;
FileSystemInfoList m_fsInfosCache;
QMutex m_fsInfosCacheLock;

QMutex m_downloadURLsLock;
4 changes: 2 additions & 2 deletions mythtv/programs/mythbackend/scheduler.cpp
Original file line number Diff line number Diff line change
@@ -5692,15 +5692,15 @@ int Scheduler::FillRecordingDir(

void Scheduler::FillDirectoryInfoCache(void)
{
QList<FileSystemInfo> fsInfos;
FileSystemInfoList fsInfos;

m_fsInfoCache.clear();

if (m_mainServer)
m_mainServer->GetFilesystemInfos(fsInfos, true);

QMap <int, bool> fsMap;
QList<FileSystemInfo>::iterator it1;
FileSystemInfoList::iterator it1;
for (it1 = fsInfos.begin(); it1 != fsInfos.end(); ++it1)
{
fsMap[it1->getFSysID()] = true;