Remove Qt3 code from libmythupnp #1056
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replacing BufferedSocketDevice and removing the now unused Qt3 internal MMembuf. ~QTcpSocket() closes the connection if necessary, so I saw no reason to close it before then.
Its use was removed in 2021 in 36f21e9.
Use removed in 2017 in 79844ba.
This has not locked for the address list since 2008 with 0a3cbf5. The only change is that UPnpNotifyTask::m_eNTS may now change, which is only read to determine if the datagram should be sent twice.
It has been unused since 85bb976 in 2007. No packets should be received from the broadcast address 255.255.255.255 (they should have the sender's IP address), so there is never any data to read from that socket in SSDP::run().
This temporarily breaks receipt of ssdp:discover replies since nothing is listening on the search port they will be sent back to.
…cket The replies will now be sent to a random port without a listener, which will be remedied later.
creating SSDPReceiver. Qt moc annoyingly errors on nested classes. SSDP is no longer an MThread, but is still a singleton.
5 tasks
The replies will be sent to the source port, so we need to send from the same port we are listening on. I couldn't get this to work with the old Qt3 code with only listening on one port.
On my LAN, almost all connected in under 1 ms. Unfortunately, this appears to only loop in the main CoreContext/UI thread.
to ensure the replies are sent to the listening socket address and port.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the replacements added in Qt4: QTcpSocket and QUdpSocket.
The receipt of ssdp:discover replies was briefly broken during the conversion.
SSDP is no longer its own thread, revealing that PortChecker blocks for an unnecessarily long time, which made the fade in animation on startup of mythfrontend very slow.
Checklist