Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depup redis #301

Merged
merged 10 commits into from
Jan 29, 2025
Merged

Depup redis #301

merged 10 commits into from
Jan 29, 2025

Conversation

Rossb0b
Copy link
Member

@Rossb0b Rossb0b commented Jan 28, 2025

No description provided.

@Rossb0b Rossb0b self-assigned this Jan 28, 2025
@socket-security Socket Security
Copy link

socket-security bot commented Jan 28, 2025 •
edited
Loading

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@myunisoft/[email protected] 🔁 npm/@myunisoft/[email protected] Transitive: environment, network +11 1.05 MB rossbob

View full report↗︎

@Rossb0b Rossb0b marked this pull request as ready for review January 29, 2025 08:54
@Rossb0b Rossb0b requested review from PierreDemailly and fraxken and removed request for PierreDemailly January 29, 2025 08:54
@Rossb0b
Copy link
Member Author

Rossb0b commented Jan 29, 2025

Les deux UT qui sautent sont flaky btw, le fonctionnel est okay lui

PierreDemailly
PierreDemailly reviewed Jan 29, 2025
View reviewed changes
src/types/eventManagement/index.ts Outdated
@@ -1,4 +1,4 @@
export type Prefix = "test" | "development" | "staging" | "production";
export type Prefix = "test";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

events/docs/class/dispatcher.md

Line 27 in 581ac79

type Prefix = "test" | "development" | "staging" | "production";

Faut modifier la doc ?
D'ailleurs je me demande si il faut pas carrément virer ce Prefix ? C'est utilisé juste pour l'initialisation de l'Externals c'est ça ? On a deja l'option externalsInitialized et l'env MYUNISOFT_EVENTS_INIT_EXTERNAL

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes en effet

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rossb0b Du coup il faut update la doc aussi 😋

@Rossb0b Rossb0b merged commit bf29c94 into main Jan 29, 2025
7 checks passed
@Rossb0b Rossb0b deleted the depup-redis branch January 29, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreDemailly PierreDemailly PierreDemailly left review comments

@fraxken fraxken fraxken approved these changes

@Dafyh Dafyh Dafyh approved these changes

Assignees

@Rossb0b Rossb0b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rossb0b @fraxken @PierreDemailly @Dafyh