Skip to content
This repository was archived by the owner on Feb 3, 2025. It is now read-only.

Skip hermes check if we don't have a ln address #1221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip hermes check if we don't have a ln address #1221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions mutiny-core/src/hermes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,11 @@ impl<S: MutinyStorage> HermesClient<S> {
o.name
);
*c = (o.name.clone(), true);

// if we don't have a lightning address, no need to continue
if o.name.is_none() {
break;
}
Comment on lines +183 to +187
Copy link
Contributor

@AnthonyRonning AnthonyRonning Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems strange to me about this code. I think this works, but would it make more sense to have Ok(Some(u)) and Ok(None)? It would probably need to do the same current_address_check_clone stuff but make be more logical to seperate when the user has a name registered and not.

}

// check that federation is still the same
Expand Down