fix: docs dashboard — graph edges, stats counting, model/provider resolution#689
Merged
Conversation
…e fix The frontend merged all workflows into a single flat Record<string, Action> with collision-based prefixing (wfId__actionName). This broke edges in the workflow graph because deps referenced unprefixed names while node IDs were prefixed. It also required double-lookup hacks in data-screen.tsx. Root fix: always key actions as wfId/actionName. No collision detection, no conditional prefixing, no dep fixup pass. - transformers.ts: key = wfId/actionName, remove collision logic - dag-transformer.ts: node IDs use full key, deps resolve within workflow scope, skip deps that don't map to a node (e.g., "source") - actions-screen.tsx: display short name, use full key for lookups, resolve dep clicks within workflow - workflows-screen.tsx: display short name, resolve dep clicks - data-screen.tsx: use wfId/actionName directly (no double-lookup) - command-search.tsx: display short name
Muizzkolapo
force-pushed
the
fix/docs-lineage-edges
branch
from
64cd384 to
8036093
Compare
Two bugs in the catalog generator:
1. Stats counted action.get("kind") but parser stores action["type"].
Result: llm_actions=0, tool_actions=0 in every catalog.
2. Model/provider not inherited from workflow defaults. Parser only
checked action-level config, ignoring defaults. Result: every
action showed model="unknown", provider="unknown".
Rebuilt frontend out/ and docs_site/.
Muizzkolapo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three bugs in the docs dashboard fixed:
Graph edges missing — when two workflows share action names, the frontend merged all actions into one flat dict with collision-based prefixing (
wfId__actionName). Deps referenced unprefixed names → ReactFlow silently dropped all edges. Fix: always scope keys aswfId/actionName, resolve deps within workflow scope.Stats show llm_actions=0, tool_actions=0 — generator checked
action.get("kind")but parser storesaction["type"]. Fix:"kind"→"type".Model/provider show "unknown" — parser only checked action-level config, ignoring workflow defaults. Fix: fall back to
defaults.get("model_vendor")/defaults.get("model_name").Files changed
Frontend (namespace fix)
lib/transformers.tswfId/actionName, remove collision logiclib/dag-transformer.tscomponents/screens/actions-screen.tsxcomponents/screens/workflows-screen.tsxcomponents/screens/data-screen.tsxwfId/actionNamelookup (removes double-lookup hack)components/command-search.tsxBackend (data generation)
generator.pyaction.get("kind")→action.get("type")parser.pyVerification
npm run buildpassespytest→ 7494 passed, 2 skippedruff check→ all checks passed