Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏷️ Convert to ES Modules and NodeNext #314

Merged
merged 11 commits into from
Jan 2, 2025

Conversation

NatoBoram
Copy link

@NatoBoram NatoBoram commented May 24, 2024

Motivation

https://www.typescriptlang.org/tsconfig/#verbatimModuleSyntax

When using verbatimModuleSyntax in a consuming app, compilation fails because Jira.js is a CommonJS library in TypeScript. This can be fixed with disableSourceOfProjectReferenceRedirect, but it's a bit of a shame to lose access to the source code when you have it right there. A better option would be to migrate the library to modern JavaScript standards and improve performance and compatibility along the way.

Changes

References

CI

@NatoBoram
Copy link
Author

Rebased to v4.0.2

@MrRefactoring MrRefactoring changed the base branch from master to release/v5.0.0 January 2, 2025 02:24
@MrRefactoring MrRefactoring merged commit a40e1f3 into MrRefactoring:release/v5.0.0 Jan 2, 2025
@NatoBoram NatoBoram deleted the feature/esm branch January 7, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants