🏷️ Convert to ES Modules and NodeNext #314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://www.typescriptlang.org/tsconfig/#verbatimModuleSyntax
When using
verbatimModuleSyntax
in a consuming app, compilation fails because Jira.js is a CommonJS library in TypeScript. This can be fixed withdisableSourceOfProjectReferenceRedirect
, but it's a bit of a shame to lose access to the source code when you have it right there. A better option would be to migrate the library to modern JavaScript standards and improve performance and compatibility along the way.Changes
verbatimModuleSyntax
Migrate fromRebased onava
tovitest
v4.0.2
paths
intsconfig.json
References
feature/esm
coderabbitai/jira.js#1moduleResolution
toNodeNext
, tsc won't compile paths alias microsoft/TypeScript#56350