Merge Prototype Branch Work #13584

robdivincenzo · 2025-03-06T21:46:23Z

Description

This PR will officially kick off the new redesign branch. It includes:

All existing prep work with reformatted codebase from Redesign codebase prep #13546 (note, this is sync'ed w/ main for smooth transition)
All current prototype branch work merged and migrations squashed
A new homepage and site factory
A new load_fake_data function into existing workflows
Set up the "redesign" homepage and blog pages as the default site.
Set up all the old fake pages onto a legacy.localhost:8000 site

Link to sample test page: https://foundation-s-redesign-m-03z3ng.herokuapp.com/en/
Related PRs/issues: #13546

┆Issue is synchronized with this Jira Story

… load_fake_data command into build process

Bumps [eslint](https://github.com/eslint/eslint) from 9.19.0 to 9.21.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v9.19.0...v9.21.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [django](https://github.com/django/django) from 4.2.16 to 4.2.20. - [Commits](django/django@4.2.16...4.2.20) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [axios](https://github.com/axios/axios) from 1.7.4 to 1.8.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.7.4...v1.8.2) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [postcss](https://github.com/postcss/postcss) from 8.5.1 to 8.5.3. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.5.1...8.5.3) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…HOSTS

danielfmiranda

Amazing work @robdivincenzo! 🙌 I have taken a look and everything is looking good to me. Cant wait to get started on the new site work!

Approved 👍

mmmavis

Thanks for the amazing work, @robdivincenzo! I noticed that the get_domain_site_mapping implementation in review_app_setup.py hasn't been updated. No worries if we’re planning to make that change in the redesign branch, but I wanted to flag it in case setting up review apps for the new site, legacy site, MozFest, and Donate is a priority for this PR :)

mmmavis · 2025-03-10T22:56:02Z

foundation_cms/legacy_apps/mozfest/factory.py

-    if tds and len(tds) > 1:
-        # Assume that tds[0] is the main mofo domain, and tds[1] is the Mozfest domain
-        hostname = tds[1]
+    if tds and len(tds) > 2:


🙈 We probably should come up with a more future-proof check here. @robdivincenzo could you please add a FIXME or TODO notes here?

Thanks @mmmavis! TIL about that command 😆, I will take a look through. For sure can add a TODO to clean that situation up. I just snagged the mozfest code and incremented for another site for now lol

Hey @mmmavis! I've updated the domains (switching the unused donate- for legacy-) and added a handful of TODO / FIXME. Turns out the review_app_setup.py needs some TLC in general. The delete DNS record isn't working, and we've got 1,800+ DNS entries for mofostaging.net.

I think that'd be outside the scope of this PR, but we should absolutely revisit how our review app and sites scripts set things up.

Thanks for looking into this, @robdivincenzo !

foundation_cms/legacy_apps/wagtailpages/factory/homepage.py

dlopezvsr

Thanks for the great work @robdivincenzo and for putting all this together. Everything looks good to me 🚀 Looking forward to start working with redesign branch too!

…IXME & TODOs

mmmavis

✨

robdivincenzo and others added 16 commits March 6, 2025 16:42

Merge prototype work, create homepage and site factory, integrate new…

48006e9

… load_fake_data command into build process

Merge branch 'redesign' into redesign-merge-prototype-work

e742581

Merge branch 'redesign' into redesign-merge-prototype-work

2bbc989

Merge remote-tracking branch 'origin' into redesign-merge-prototype-work

84a1b7d

Migrations squash and catchup

1fd221c

Alter site for legacy tests

df35d54

linting

0b9bead

Update CI to lint check legacy only, add legacy.localhost to ALLOWED …

05be21b

…HOSTS

Missing HOSTS

82f49cd

Remove subpage type restriction

f57b0c1

Update homepage test because /en/ is default locale

45e6738

Update test case to use new homepage factory

69b06bb

robdivincenzo deployed to foundation-s-redesign-m-pk4ni3 March 10, 2025 15:57 View deployment

Add additional domain for mozfest

05019e1

robdivincenzo temporarily deployed to foundation-s-redesign-m-pk4ni3 March 10, 2025 16:28 Inactive

mofodevops temporarily deployed to foundation-s-redesign-m-viywg1 March 10, 2025 16:29 Inactive

robdivincenzo temporarily deployed to foundation-s-redesign-m-03z3ng March 10, 2025 16:50 Inactive

robdivincenzo marked this pull request as ready for review March 10, 2025 17:17

robdivincenzo requested review from mmmavis, danielfmiranda, dlopezvsr and ramram-mf March 10, 2025 17:18

Remove missing static css and js since frontend dev has not started

5f96349

robdivincenzo temporarily deployed to foundation-s-redesign-m-03z3ng March 10, 2025 17:38 Inactive

danielfmiranda approved these changes Mar 10, 2025

View reviewed changes

mmmavis reviewed Mar 10, 2025

View reviewed changes

dlopezvsr approved these changes Mar 11, 2025

View reviewed changes

Include cloudflare record for legacy- reviewapp, remove donate. Add F…

d7794be

…IXME & TODOs

robdivincenzo temporarily deployed to foundation-s-redesign-m-03z3ng March 11, 2025 16:22 Inactive

robdivincenzo added the run visual regression tests label Mar 11, 2025

Add fixme

0f5a395

robdivincenzo deployed to foundation-s-redesign-m-03z3ng March 11, 2025 16:51 View deployment

robdivincenzo added run visual regression tests and removed run visual regression tests labels Mar 11, 2025

mmmavis approved these changes Mar 12, 2025

View reviewed changes

robdivincenzo merged commit 75df37a into redesign Mar 13, 2025
8 of 9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge Prototype Branch Work #13584

Merge Prototype Branch Work #13584

robdivincenzo commented Mar 6, 2025 •

edited

Loading

danielfmiranda left a comment

mmmavis left a comment

mmmavis Mar 10, 2025

robdivincenzo Mar 11, 2025 •

edited

Loading

robdivincenzo Mar 11, 2025 •

edited

Loading

mmmavis Mar 12, 2025

dlopezvsr left a comment

mmmavis left a comment

Merge Prototype Branch Work #13584

Merge Prototype Branch Work #13584

Conversation

robdivincenzo commented Mar 6, 2025 • edited Loading

Description

danielfmiranda left a comment

Choose a reason for hiding this comment

mmmavis left a comment

Choose a reason for hiding this comment

mmmavis Mar 10, 2025

Choose a reason for hiding this comment

robdivincenzo Mar 11, 2025 • edited Loading

Choose a reason for hiding this comment

robdivincenzo Mar 11, 2025 • edited Loading

Choose a reason for hiding this comment

mmmavis Mar 12, 2025

Choose a reason for hiding this comment

dlopezvsr left a comment

Choose a reason for hiding this comment

mmmavis left a comment

Choose a reason for hiding this comment

robdivincenzo commented Mar 6, 2025 •

edited

Loading

robdivincenzo Mar 11, 2025 •

edited

Loading

robdivincenzo Mar 11, 2025 •

edited

Loading