Refactor footer language switcher from <select> to seo-friendly <a>
#13484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns' of github-mf:MozillaFoundation/foundation.mozilla.org into TP1-1757-investigation-localization-fixes-reccomendations
mmmavis
requested changes
Feb 14, 2025
There was a problem hiding this comment.
Thanks for updating the language switcher to enhance our SEO, @ramram-mf ! I noticed that the switcher is not fully keyboard accessible. Could you take a look at the following issues?
- The switcher cannot be focused (tapped into) using the keyboard.
- When the list is open, users are unable to navigate through the options using the keyboard.
- The list cannot be closed using the keyboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the footer language switcher from an auto-submitting form with
<select>and<option>tags, in to a more seo-friendly list of links<a>tags.It aims to provide a pixel-perfect replacement for visual regression tests while ensuring an accessible interface for users with diverse input methods.
Current dropdown:
Updated dropdown:
Link to sample test page: https://foundation-s-tp1-1757-i-xhp2iv.herokuapp.com/en/
Related PRs/issues: https://mozilla-hub.atlassian.net/browse/TP1-1757
┆Issue is synchronized with this Jira Story