Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'getMin'/'getMax' to Rectangled/f/i #26

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

skaldarnar
Copy link
Member

@skaldarnar skaldarnar commented Apr 1, 2021

This PR adds two missing getters to retrieve the min and max corners of the rectangle as Vector2i/f/d.

Extracted from #23.

@skaldarnar skaldarnar requested review from jdrueckert and pollend April 1, 2021 18:47
@skaldarnar skaldarnar changed the title feat: add 'getMin'/'getMax' to Rectanglef/d feat: add 'getMin'/'getMax' to Rectanglei/f/d Apr 1, 2021
@skaldarnar skaldarnar added the enhancement New feature or request label Apr 1, 2021
@skaldarnar skaldarnar force-pushed the feat/rectangle-min-max branch from e0556e3 to 3436bfc Compare April 1, 2021 19:08
@skaldarnar skaldarnar changed the title feat: add 'getMin'/'getMax' to Rectanglei/f/d feat: add 'getMin'/'getMax' to Rectangled/f/i Apr 1, 2021
@skaldarnar skaldarnar merged commit 39b7dc9 into main Apr 1, 2021
@skaldarnar skaldarnar deleted the feat/rectangle-min-max branch April 1, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants