Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Added configurations to apply constraints to dependencies resolves #134 #159

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Thedrogon
Copy link

Added configurations to apply constraints to the build.gradle dependencies to prevent gestalt pulling in dependencies with known CVEs, directly or transitively through things like Reflections. Added some suppressions in various files and as well removed some unnecessary imports

…ent `gestalt` pulling in dependencies with known CVEs, directly or transitively through things like Reflections. Added some suppressions in various files and as well removed some unnecessary imports
@Thedrogon Thedrogon changed the title build: Added configurations to apply constraints to dependencies build: Added configurations to apply constraints to dependencies Jan 26, 2025
@Thedrogon Thedrogon changed the title build: Added configurations to apply constraints to dependencies build: Added configurations to apply constraints to dependencies resolves #134 Jan 26, 2025
Copy link
Contributor

@BenjaminAmos BenjaminAmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Constraining the dependencies is a useful adjustment but I would rather it was not bundled with other wide-sweeping changes. Suppressing warnings is a last resort as well, since usually we want to see warnings.

… to prevent `gestalt` pulling in dependencies with known CVEs, directly or transitively through things like Reflections. Added some suppressions in various files and as well removed some unnecessary imports"

This reverts commit 43923eb.
Copy link
Author

@Thedrogon Thedrogon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted the changes .

…s of (deprecated)access-controller so that it can be removed without errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants