-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First setup of github action for automated blender testing #584
Conversation
Making progress, but seems at least one run had a crash. Still not 100% all files are in place, but the fact that it was trying to load the file seems to be a positive sign. Going to do some more isolated tests for just single sets of test classes at a time.
|
I'm going to wager "no" to files not all being in place, given the latest run limited to just the materials tests:
|
Ok I've ruled it down to this: the actual addon install wasn't happening as far as I could tell, sorted now by ensuring we explicitly create the target install folder before running bpy addon build. With that working now, more of the tests are passing, but there's a few others still. Going one class at a time. Might have a json / env loading issue, since we're not picking up this file (likely affecting the tests in question). I'll get back to this tomororw.
|
Making progress at understanding the area that went wrong. It does seem it's loading the mcprep data json, but somehow we only have these keys:
... it's dropping/not loading the "non_color_options" which these tests depend on. I can't figure out where this partial json is coming from though, seems very strange. |
Oh. The problem is that we are not using the checked in json file, but rather extracting the one from |
Welp, that's official! Tests are running 100% on github actions across all (at least for blender 4.1.1). I'll do a separate test in a moment across all the targeted blender versions. This run's results:
|
Hey @StandingPadAnimations this is finally ready for review. Looks like it runs pretty stable now too, which is great. Once this is merged into main (after merging into dev first, ofc) we will then also have an option to go to the actions tab and select which versions of blender to run against per the choice enum in the workflow title. By default to save on github minutes, I'm just having it run the 4.1.1 build. But the matrix array should work to run against all those other versions, useful for release prep. Let me know if you have any feedback. As a side note, other than making sure the right files like the json and ahem after |
As a complete note to self, something rather bizzare I just noticed: the github minutes are counting against my own account as opposed to the Moo-Ack! Productions org quota. Doesn't matter since A) they are the same and B) we'd have to go real crazy to use up all minutes, as in like 2,000 individual commits-crazy (onto branches already opened as PRs). So I'm not concerned about that at this stage. Worst case scenario, we can reduce the tests to only run on manual dispatch and on PR opened (vs every commit, as it is now). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
This PR aims to add automated testing for new PRs by downloading blender and running our test suite.
Get ready for a large number of one-line commits as I slowly work on getting this to work. Not actually ready to review, I'm just working on the triggers primarily.