Harden Prime ENS operator docs and size reporting#161
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48acb475d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name: "ENSJobPages", | ||
| artifactPath: artifactPathFor("ens/ENSJobPages.sol", "ENSJobPages"), | ||
| enforce: process.env.STRICT_ENS_SIZE === "1", |
There was a problem hiding this comment.
Restore the default size gate for deployable ENSJobPages
.github/workflows/ci.yml:36-37 runs npm run test:prime:ci, which includes npm run test:size, and hardhat/scripts/deploy-ens-job-pages.js:137-139 deploys this exact ENSJobPages artifact on-chain. Making its limit check opt-in here means the canonical size lane now exits 0 even when the helper is already over the EIP-170/EIP-3860 limits (the commit message explicitly says it is "oversized"), so CI no longer protects the replacement-helper deploy path and operators only discover the problem when factory.deploy() reverts on mainnet/sepolia.
Useful? React with 👍 / 👎.
Motivation
useEnsJobTokenURIis legacy-manager-only.Description
scripts/check-bytecode-size.jswithout weakening existing Prime baseline enforcement by: adding ENSJobPages/ENSJobPagesInspector to the checks list and making ENS checks report-only unlessSTRICT_ENS_SIZE=1is set.scripts/ens/output/change-minimization-plan.jsonsummarizing the selected Option B approach.agijob-prefix, removed/marked legacyuseEnsJobTokenURIassumptions, documented keeper-assisted metadata model and explicit repair flows). Files updated include:docs/*(multiple ENS/runbook files listed in commit).test/ensAuthoritySnapshot.test.js,test/ensKeeperAssistedPrimePath.test.js) to match the current lean Prime / keeper-assisted flow (use ENS-side owner calls in tests and assert manager public getters rather than nonexistent V1 getters).Testing
npm run test:size; passed and confirmedAGIJobManagerPrimeruntime remains at baseline (24,472 bytes) and ENSJobPages size is reported (oversized) as report-only by default.npm run test:size:benchmark; passed and reconfirmed best EIP-170-safe compile profile for Prime (viaIR=true, runs=1).npm run docs:check && npm run docs:ens:check; documentation checks passed.npx truffle test --network test test/ensAuthoritySnapshot.test.js test/ensKeeperAssistedPrimePath.test.js; tests passed after aligning expectations to the keeper-assisted path (11 passing).npm run ens:phase0:mainnetbut it hit an external RPC 502 from the public node duringeth_getLogsin this environment (network/RPC availability issue), not a repo failure.Codex Task