Harden ENSJobPages resolver handling, portable ENS audit tooling, and docs/artifacts refresh #154
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| const { createRequire } = require('node:module'); | ||
| const path = require('node:path'); | ||
|
|
||
| const requireFromHere = createRequire(__filename); | ||
|
|
||
| function loadEthers() { | ||
| const candidates = [ | ||
| path.resolve(__dirname, '../../../hardhat/node_modules/ethers'), | ||
| 'ethers', | ||
| ]; | ||
|
Comment on lines
+7
to
+10
There was a problem hiding this comment.
This new helper does not make the ENS operator scripts portable end-to-end yet. Useful? React with 👍 / 👎. |
||
|
|
||
| for (const candidate of candidates) { | ||
| try { | ||
| const mod = requireFromHere(candidate); | ||
| return mod.ethers || mod; | ||
| } catch (error) { | ||
| if (candidate === candidates[candidates.length - 1]) throw error; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| const raw = loadEthers(); | ||
| const isV6 = typeof raw.ZeroAddress === 'string'; | ||
|
|
||
| function compat() { | ||
| if (isV6) return raw; | ||
| const utils = raw.utils; | ||
| return { | ||
| ...raw, | ||
| ZeroAddress: raw.constants.AddressZero, | ||
| ZeroHash: raw.constants.HashZero, | ||
| Interface: utils.Interface, | ||
| Wallet: raw.Wallet, | ||
| id: utils.id, | ||
| namehash: utils.namehash, | ||
| ensNormalize: (value) => value.trim().toLowerCase(), | ||
| solidityPackedKeccak256: (types, values) => utils.solidityKeccak256(types, values), | ||
|
Comment on lines
+25
to
+39
There was a problem hiding this comment.
When Useful? React with 👍 / 👎.
Comment on lines
+34
to
+39
There was a problem hiding this comment.
The v5 branch returns Useful? React with 👍 / 👎. |
||
| }; | ||
|
Comment on lines
+28
to
+40
There was a problem hiding this comment.
In the standalone Useful? React with 👍 / 👎. |
||
| } | ||
|
|
||
| module.exports = { ethers: compat() }; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any resolver that exposes a readable
text(bytes32,string)surface but does not actually implementsetText/setAuthorisationnow passesvalidateConfiguration(). In that setuphandleHook()will proceed, create/adopt the subname, and emitENSHookProcessed(..., configured=true, success=true)because_setTextBestEffort()and_setAuthorisationBestEffort()swallow the missing-function reverts, but the page never gets metadata or permissions andjobEnsReady()stays false. Before this change the ERC-165 write-interface checks prevented that silent misconfiguration.Useful? React with 👍 / 👎.