Skip to content

Enhance ENS/Identity flows, mission control UX, and ENSJobPages ABI handling#1481

Open
MontrealAI wants to merge 2 commits into
mainfrom
codex/upgrade-agijobmanager-html-to-v29-c7oiwf
Open

Enhance ENS/Identity flows, mission control UX, and ENSJobPages ABI handling#1481
MontrealAI wants to merge 2 commits into
mainfrom
codex/upgrade-agijobmanager-html-to-v29-c7oiwf

Conversation

@MontrealAI
Copy link
Copy Markdown
Owner

Motivation

  • Improve reliability and clarity of ENS job-page preview and Alpha Agent identity workflows for mainnet operators by hardening contract calls and UX copy.
  • Surface clearer mission-control guidance and action buttons for identity, bridging, and validator/agent paths.
  • Fix and extend the ENSJobPages ABI and add robust fallback behavior when ENS contracts are partially unavailable.

Description

  • Extended and reordered the ENSJobPagesABI and related ABIs to include missing accessors (owner, ens, nameWrapper, publicResolver, jobLabelPrefix, nextJobId, jobLabelSnapshot, etc.) and adjusted usages accordingly.
  • Reworked updateEnsJobPagePreview to prefer the ENSJobPages contract for nextJobId with a fallback to agiJobManager, and improved snapshot/label extraction and defensive .call() error handling.
  • Refactored identity and registrar handling (parseIdentityPreviewResult, refreshIdentityState) to normalize returned shapes, tighten root-node mismatch detection, improve mismatch warnings, adjust UI field population order, and harden tokenURI parsing and display logic.
  • Refactored role verification (verifySubdomain) to use a runtime name wrapper address fallback, more robust resolver checks, clearer status messages, and cleaner verification state updates.
  • Updated mission-control copy and button logic to make primary/secondary actions clearer across identity, bridge, validator, and agent states, and changed some small UI copy (e.g., the Command Center note for v29).
  • Miscellaneous safety and UX tweaks including improved error messaging, whitespace/formatting cleanups, and removal of transaction hash from identity action toast to reduce clutter.

Testing

  • Built the UI with npm run build and the build completed successfully.
  • Ran the test suite with npm test and the automated tests passed.
  • Executed automated linting (npm run lint) with no new errors reported.

Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e261fe2c5a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const tokenID = namehash(full);
const managerWrapperAddr = await agiJobManager?.methods?.nameWrapper?.().call().catch(()=>null);
const managerEnsAddr = await agiJobManager?.methods?.ens?.().call().catch(()=>null);
const managerWrapperAddr = await agiJobManager?.methods?.nameWrapper().call().catch(()=> '');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use optional lookup when reading manager nameWrapper

verifySubdomain now invokes agiJobManager?.methods?.nameWrapper().call() directly, but the AGIJobManagerABI in this file does not define nameWrapper, so this throws ...nameWrapper is not a function before fallback logic can run. In that case the outer catch marks verification as an error, which blocks agent/club ENS verification even for correctly authorized wallets.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant