Enhance ENS/Identity flows, mission control UX, and ENSJobPages ABI handling#1481
Enhance ENS/Identity flows, mission control UX, and ENSJobPages ABI handling#1481MontrealAI wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e261fe2c5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const tokenID = namehash(full); | ||
| const managerWrapperAddr = await agiJobManager?.methods?.nameWrapper?.().call().catch(()=>null); | ||
| const managerEnsAddr = await agiJobManager?.methods?.ens?.().call().catch(()=>null); | ||
| const managerWrapperAddr = await agiJobManager?.methods?.nameWrapper().call().catch(()=> ''); |
There was a problem hiding this comment.
Use optional lookup when reading manager nameWrapper
verifySubdomain now invokes agiJobManager?.methods?.nameWrapper().call() directly, but the AGIJobManagerABI in this file does not define nameWrapper, so this throws ...nameWrapper is not a function before fallback logic can run. In that case the outer catch marks verification as an error, which blocks agent/club ENS verification even for correctly authorized wallets.
Useful? React with 👍 / 👎.
Motivation
Description
ENSJobPagesABIand related ABIs to include missing accessors (owner,ens,nameWrapper,publicResolver,jobLabelPrefix,nextJobId,jobLabelSnapshot, etc.) and adjusted usages accordingly.updateEnsJobPagePreviewto prefer the ENSJobPages contract fornextJobIdwith a fallback toagiJobManager, and improved snapshot/label extraction and defensive.call()error handling.parseIdentityPreviewResult,refreshIdentityState) to normalize returned shapes, tighten root-node mismatch detection, improve mismatch warnings, adjust UI field population order, and harden tokenURI parsing and display logic.verifySubdomain) to use a runtime name wrapper address fallback, more robust resolver checks, clearer status messages, and cleaner verification state updates.Testing
npm run buildand the build completed successfully.npm testand the automated tests passed.npm run lint) with no new errors reported.Codex Task