Minor changes within the Launcher branch (but to Drivetrain, primarily) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 12, 2020 16:16
implementing these be invoked for every one of the key methods of TimedRobot, even if there is nothing to be one for that method for the specific component.
actually do anything. This makes it easier if, later, they do need to do something. That means changing one class (the Drivetrain) and not two (ie. Robot need not be changed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going to do more in this PR, but I hit numerous "little issues". For example, I wanted to pull the
LauncherStateclasses into a separate package, but was balked by the fact that these use package-private types infrc.robot.core.components.ControlSystem.I could have "fixed" that, of course, but that involves some nontrivial choices that I didn't want to make for you (nor, do I believe, should I be doing so).
So I create some issues instead. Please feel free to ask any questions about those.
Meanwhile, I'll share this minor evolution of the
ComponentandDrivetrainentities. This is probably less aboutDrivetrain(though it should make maintaining and enhancing it easier) and more about other classes that will implementComponentin the future (ie.Launcher- see #3 ).