groupOrder spec#80
Open
jimmyhuang1992 wants to merge 2 commits intodevelopfrom
Open
Conversation
horsekitlin
reviewed
Aug 28, 2018
| @@ -92,69 +102,87 @@ describe(`models/${modelName}`, () => { | |||
| let modelDateForFind = null; | |||
| before(async () => { | |||
Contributor
There was a problem hiding this comment.
(好奇)
before 為什麼要拆開呢？
我看每一筆資料都不一樣
因為都在測試同樣一個 model
可以整理在一個 describe
在 before 統一新增
是有什麼特別的考量麻？
Member
Author
There was a problem hiding this comment.
我不是很確定對不對,
像是底下 describe('Find all model data'） 它的 before 裡 新增資料是用 .bulkCreate(）增加一個陣列型式的多筆資料;
create() 是增加一筆物件資料
Contributor
There was a problem hiding this comment.
新增多筆或是新增一筆部會影響到放在同一個 before 裡面做歐
我的問題是同樣一個 model 的測試
before 為什麼要拆開呢？
因為如果要分開的話
應該也有 beforeEach 的 function 可以使用
而且這些 Data 彼此之間也沒有互相干擾
這樣實作沒有問題拉
只是好奇是不是有什麼特別的考量才選擇這樣的方式
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.