Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOP-23122] Use async methods of Keycloak client #177

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[DOP-23122] Use async methods of Keycloak client #177

wants to merge 1 commit into from

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Dec 23, 2024 •
edited
Loading

Change Summary

  • Do not call blocking methods of Keycloak client inside async def methods of AuthProvider.
  • Fix annotations for get_current_user method.
  • Replace except Exception with catching only specific exception types
  • Update user fixtures to use unique user names, allowing run the same test multiple times.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Dec 23, 2024
@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dolfinus dolfinus

Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dolfinus