Add max_compatibility_level = 3 for rules_swift dep#3298
Closed
jpsim wants to merge 1 commit intoMobileNativeFoundation:mainfrom
Closed
Add max_compatibility_level = 3 for rules_swift dep#3298jpsim wants to merge 1 commit intoMobileNativeFoundation:mainfrom
jpsim wants to merge 1 commit intoMobileNativeFoundation:mainfrom
Conversation
The upcoming `rules_swift` release bumps `compatibility_level` from 2 to 3. Without `max_compatibility_level = 3` on the `bazel_dep`, Bzlmod rejects the resolution when downstream projects use that release (or a git override at a commit past the bump). Other modules in the ecosystem (`rules_apple`, `rules_swift_package_manager`, `swift-syntax`, `swift-index-store`) already declare this. Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
force-pushed
the
jp/rules-swift-max-compat-level
branch
from
a772281 to
ab25736
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_compatibility_level = 3to therules_swiftbazel_depinMODULE.bazelrules_swiftrelease bumpscompatibility_levelfrom 2 to 3, which breaks Bzlmod resolution for downstream projects unless dependents declaremax_compatibility_level = 3rules_apple,rules_swift_package_manager,swift-syntax,swift-index-store) already declare thisTest plan
rules_swiftgit override at a commit past thecompatibility_level = 3bump (e.g.00e74b8)