Connects to #369. PASS1AC-06 phenotype data analysis (initial phase). #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld components of pass1b and pass1a pheno data analysis
…components for summary statistics
… summary statistics plots
…ss1a-06 pheno data analysis
…_Dawg_Pac_Pheno_Data_Analysis
There was a problem hiding this comment.
Copilot reviewed 8 out of 23 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- package.json: Language not supported
- src/AnalysisPage/Phenotype/pass1ac-animal_pheno.json: Language not supported
- src/AnalysisPage/Phenotype/Components/Pass1ac-06/sharedLib.js: Evaluated as low risk
- src/AnalysisPage/Phenotype/pass1a06Rats.jsx: Evaluated as low risk
- src/AnalysisPage/Phenotype/Components/Pass1ac-06/correlationAnalyses/categoryCorrelationAnalyses.jsx: Evaluated as low risk
- src/AnalysisPage/Phenotype/Components/Pass1ac-06/correlationAnalyses/plotOverallCorrelationMatrix.jsx: Evaluated as low risk
- src/AnalysisPage/Phenotype/Components/Pass1ac-06/chartWrapper.jsx: Evaluated as low risk
- src/AnalysisPage/Phenotype/Components/Pass1ac-06/analysisCategoryNavigation.jsx: Evaluated as low risk
- src/AnalysisPage/Phenotype/Components/Pass1ac-06/correlationAnalyses/sectionOverallCorrelationMatrix.jsx: Evaluated as low risk
- src/AnalysisPage/Phenotype/pass1b06Rats.jsx: Evaluated as low risk
- src/AnalysisPage/pass1b06PhenotypeAnimal.jsx: Evaluated as low risk
- src/AnalysisPage/analysisActions.js: Evaluated as low risk
- src/AnalysisPage/analysisReducer.js: Evaluated as low risk
- src/AnalysisPage/Phenotype/Components/Pass1ac-06/SummaryStatistics/sectionWeightDistribution.jsx: Evaluated as low risk
- src/AnalysisPage/Phenotype/Components/Pass1ac-06/SummaryStatistics/plotWeightDistribution.jsx: Evaluated as low risk
Comments suppressed due to low confidence (3)
src/AnalysisPage/Phenotype/Components/Pass1ac-06/SummaryStatistics/plotLactateChange.jsx:20
- [nitpick] The function name getLactateChangeData could be more descriptive. Consider renaming it to extractLactateChangeData.
const getLactateChangeData = (data) => data.map((item) => parseFloat(item.lactate_change));
src/AnalysisPage/Phenotype/Components/Pass1ac-06/SummaryStatistics/plotRatWork.jsx:21
- Use parseInt with a radix to avoid unexpected results. Change to parseInt(item.weight, 10).
const weight = parseInt(item.weight, 10) / 1000;
src/AnalysisPage/Phenotype/Components/Pass1ac-06/SummaryStatistics/plotRatWork.jsx:22
- Use parseInt with a radix to avoid unexpected results. Change to parseInt(item.distance, 10).
const distance = parseInt(item.distance, 10);
src/AnalysisPage/Phenotype/Components/Pass1ac-06/SummaryStatistics/sectionRatWork.jsx
Outdated
Show resolved
Hide resolved
src/AnalysisPage/Phenotype/Components/Pass1ac-06/SummaryStatistics/sectionLactateChange.jsx
Outdated
Show resolved
Hide resolved
…tics/sectionRatWork.jsx Fix typo Co-authored-by: Copilot <[email protected]>
…tics/sectionLactateChange.jsx Fix typo Co-authored-by: Copilot <[email protected]>
…PAC/motrpac-frontend into 369_JZ_Dawg_Pac_Pheno_Data_Analysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new components and features for the PASS1AC-06 phenotypic data analysis, particularly focusing on summary statistics and correlation analyses. The most important changes include the addition of new components for rendering various plots and sections, as well as the integration of a new library for statistical calculations.
New components for summary statistics and correlation analyses:
src/AnalysisPage/Phenotype/Components/Pass1ac-06/SummaryStatistics/categorySummaryStatistics.jsx: Added a new component to render the summary statistics category, including sections for weight distribution, lactate change, and rat work.src/AnalysisPage/Phenotype/Components/Pass1ac-06/SummaryStatistics/plotLactateChange.jsx: Added a new component to render plots for lactate change using Highcharts.src/AnalysisPage/Phenotype/Components/Pass1ac-06/SummaryStatistics/plotRatWork.jsx: Added a new component to render plots for rat work using Highcharts.src/AnalysisPage/Phenotype/Components/Pass1ac-06/SummaryStatistics/plotWeightDistribution.jsx: Added a new component to render plots for weight distribution using Highcharts.src/AnalysisPage/Phenotype/Components/Pass1ac-06/correlationAnalyses/plotOverallCorrelationMatrix.jsx: Added a new component to render plots for overall correlation matrix using Highcharts.src/AnalysisPage/Phenotype/Components/Pass1ac-06/analysisCategoryNavigation.jsx: Added a new component for navigating between different analysis categories.Integration of new library:
package.json: Addedsimple-statisticslibrary for statistical calculations.PASS1AC-06 data freeze release notes:
src/MultiOmicsWorkingGroups/dawgPAC.jsxAdded JSX markup for data freeze release notes and resources.