Skip to content

Conversation

MoOx
Copy link
Owner

@MoOx MoOx commented Apr 3, 2025

No description provided.

@MoOx MoOx requested a review from Copilot April 3, 2025 16:29
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request rebuilds the project with TypeScript while cleaning up and modernizing various parts of the codebase. Key changes include:

  • Introducing a new TypeScript file (adjust-svg.ts) with helper functions for SVG cleanup and transformation.
  • Removing the old JavaScript CLI entry point (bin.js).
  • Updating the README and GitHub workflow to reflect the new TypeScript support and to use updated action versions.

Reviewed Changes

Copilot reviewed 86 out of 102 changed files in this pull request and generated 2 comments.

File Description
src/adjust-svg.ts Introduces TypeScript helper functions for adjusting and cleaning SVGs.
bin.js Removes the legacy CLI entry point.
README.md Updates documentation to include TypeScript support and revised social links.
.github/workflows/build.yml Upgrades workflow steps (e.g., Node and caching) to newer versions.
Files not reviewed (16)
  • .husky/pre-push: Language not supported
  • tests/TransformNative.res: Language not supported
  • tests/TransformNativeForReScript.res: Language not supported
  • tests/TransformNativeForTypescript.res: Language not supported
  • tests/TransformWeb.res: Language not supported
  • tests/TransformWebForReScript.res: Language not supported
  • tests/fixtures/.gitignore: Language not supported
  • tests/snapshots/TransformWeb.bs.js.snap: Language not supported
  • tests/snapshots/TransformWebForReScript.bs.js.snap: Language not supported
  • bsconfig.json: Language not supported
  • package.json: Language not supported
  • src/AdjustSvg.res: Language not supported
  • src/Case.res: Language not supported
  • src/Glob.res: Language not supported
  • src/Templates.res: Language not supported
  • src/Transformer.res: Language not supported
Comments suppressed due to low confidence (2)

src/adjust-svg.ts:23

  • The replacement in injectSvgJsProps may unintentionally modify inner tag delimiters in complex SVG structures; consider targeting only the opening tag with a regex that limits the replacement to the first occurrence.
return svg.replace(">", " {...props}>");

.github/workflows/build.yml:22

  • [nitpick] If the project does not use Next.js, consider removing or modifying the 'Handle Next.js Cache' step to avoid unnecessary cache operations.
- name: Handle Next.js Cache

@MoOx MoOx merged commit a7dcd03 into main Apr 3, 2025
1 check passed
@MoOx MoOx deleted the v7 branch April 3, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant