Skip to content

Added support for glob patterns (* and ?) in SSH config Include directive parser. #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added support for glob patterns (* and ?) in SSH config Include directive parser. #689

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc08c60
Added support for glob patterns (* and ?) in SSH config Include direc…
ccanoe Apr 18, 2025
45402ae
Replace glob with cross-platform std::filesystem version
ccanoe Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/terminal/ParseConfigFile.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
// #include <string.h>
// #include <unistd.h>

#include <filesystem>
#include <fstream>
#include <iostream>
#include <string>
Expand Down Expand Up @@ -1248,7 +1249,23 @@ static int ssh_config_parse_line(const char *targethost,
if (p) {
char *filename = ssh_path_expand_tilde(p);
if (filename) {
local_parse_file(targethost, options, filename, parsing, seen);
if (strchr(filename, '*') || strchr(filename, '?')) {
std::string dir = fs::path(filename).parent_path().string();
std::string pattern = fs::path(filename).filename().string();
std::regex pattern_regex(std::regex_replace(
std::regex_replace(pattern, std::regex(R"(\.)"), R"(\.)"),
std::regex(R"(\*)"), ".*"));
for (const auto &entry :
fs::directory_iterator(dir.empty() ? "." : dir)) {
if (std::regex_match(entry.path().filename().string(),
pattern_regex)) {
local_parse_file(targethost, options,
entry.path().string().c_str(), parsing, seen);
}
}
} else {
local_parse_file(targethost, options, filename, parsing, seen);
}
}
SAFE_FREE(filename);
}
Expand Down