Skip to content

Remove chained calls in Server.GetClientAddress() #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove chained calls in Server.GetClientAddress() #124

wants to merge 2 commits into from

Conversation

cdanek
Copy link

@cdanek cdanek commented Nov 22, 2022

Removed chained calls from GetClientAddress() to help diagnose rare NRE.

Edit re: issue #123

@cdanek
Update Server.cs
1429dd2 
Removed chained calls from GetClientAddress() to help diagnose rare NRE.
@cdanek cdanek changed the title Update Server.cs Remove chained calls in Server.GetClientAddress() Dec 6, 2022
@PyrateAkananto PyrateAkananto mentioned this pull request Dec 22, 2022
Open
@PyrateAkananto
Copy link
Contributor

PyrateAkananto commented Nov 25, 2024 •
edited
Loading

GetClientAddress was improved in a different way in 2c9d26b and 6ffca35 and I assume this pull request here is obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cdanek @PyrateAkananto