Skip to content

GEOPY-2594: PGI failure on petrophysical model with air cells #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domfournier merged 6 commits into from
Mar 27, 2026
Merged

GEOPY-2594: PGI failure on petrophysical model with air cells #367

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3462147
Extrapolate air values for referenced petrophysics model
domfournier Mar 25, 2026
e7051fc
Revert "show" option for uncertainties on fem
domfournier Mar 25, 2026
c37a3eb
Merge branch 'develop' into GEOPY-2594
benk-mira Mar 25, 2026
f91942f
re-lock
domfournier Mar 26, 2026
5ebf159
Re-lock with merged simpeg
domfournier Mar 26, 2026
fae0697
Merge branch 'develop' into GEOPY-2594
benk-mira Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions simpeg_drivers-assets/uijson/fdem1d_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@
"label": "Uncertainty",
"parent": "data_object",
"dependency": "z_imag_channel",
"dependencyType": "show",
"dependencyType": "enabled",
"enabled": false,
"value": ""
},
"z_real_channel": {
Expand Down Expand Up @@ -78,7 +79,8 @@
"label": "Uncertainty",
"parent": "data_object",
"dependency": "z_real_channel",
"dependencyType": "show",
"dependencyType": "enabled",
"enabled": false,
"value": ""
},
"u_cell_size": {
Expand Down
18 changes: 12 additions & 6 deletions simpeg_drivers-assets/uijson/fdem_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@
"label": "Uncertainty",
"parent": "data_object",
"dependency": "z_imag_channel",
"dependencyType": "show",
"dependencyType": "enabled",
"enabled": false,
"value": ""
},
"z_real_channel": {
Expand Down Expand Up @@ -100,7 +101,8 @@
"label": "Uncertainty",
"parent": "data_object",
"dependency": "z_real_channel",
"dependencyType": "show",
"dependencyType": "enabled",
"enabled": false,
"value": ""
},
"y_imag_channel": {
Expand Down Expand Up @@ -131,7 +133,8 @@
"label": "Uncertainty",
"parent": "data_object",
"dependency": "y_imag_channel",
"dependencyType": "show",
"dependencyType": "enabled",
"enabled": false,
"value": ""
},
"y_real_channel": {
Expand Down Expand Up @@ -162,7 +165,8 @@
"label": "Uncertainty",
"parent": "data_object",
"dependency": "y_real_channel",
"dependencyType": "show",
"dependencyType": "enabled",
"enabled": false,
"value": ""
},
"x_imag_channel": {
Expand Down Expand Up @@ -193,7 +197,8 @@
"label": "Uncertainty",
"parent": "data_object",
"dependency": "x_imag_channel",
"dependencyType": "show",
"dependencyType": "enabled",
Comment thread
benk-mira marked this conversation as resolved.
"enabled": false,
"value": ""
},
"x_real_channel": {
Expand Down Expand Up @@ -224,7 +229,8 @@
"label": "Uncertainty",
"parent": "data_object",
"dependency": "x_real_channel",
"dependencyType": "show",
"dependencyType": "enabled",
"enabled": false,
"value": ""
},
"mesh": {
Expand Down
6 changes: 4 additions & 2 deletions simpeg_drivers/components/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from geoapps_utils.utils.importing import GeoAppsError
from geoapps_utils.utils.numerical import weighted_average
from geoh5py.data import Data, FloatData, NumericData
from geoh5py.data.data_type import GeometricDataValueMapType
from geoh5py.data.data_type import GeometricDataValueMapType, ReferencedValueMapType
from geoh5py.objects import ObjectBase
from simpeg.utils.mat_utils import (
dip_azimuth2cartesian,
Expand Down Expand Up @@ -662,7 +662,9 @@ def obj_2_mesh(data: Data, destination: ObjectBase) -> np.ndarray:

values = data.values.astype(float)

if isinstance(data.entity_type, GeometricDataValueMapType):
if isinstance(
data.entity_type, GeometricDataValueMapType | ReferencedValueMapType
):
Comment thread
domfournier marked this conversation as resolved.
values[values == 0] = np.nan
Comment thread
domfournier marked this conversation as resolved.

full_vector = weighted_average(xyz_in, xyz_out, [values], n=1)[0]
Expand Down
Loading