Skip to content

DEVOPS-1060: in github, exception on jira number check for automatic PR Bumping CI-tools #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RomFloreani merged 12 commits into from
May 13, 2026
Merged

DEVOPS-1060: in github, exception on jira number check for automatic PR Bumping CI-tools #177

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3901e35
DEVOPS-1060: fix: skip Jira checks for Dependabot PRs
RomFloreani May 11, 2026
5d7ce68
fix: skip add_jira_summary for Dependabot PRs
RomFloreani May 11, 2026
eb9dd38
Apply suggestions from code review
RomFloreani May 12, 2026
ffcc612
fix: fail get_issue_key when no Jira key found and not an expected bo…
RomFloreani May 13, 2026
012a828
fix: skip branch Jira key extraction for Dependabot branches
RomFloreani May 13, 2026
970589c
feat: run add_jira_summary on human commits to bot PRs
RomFloreani May 13, 2026
fa44f26
Ignoring zizmor checks for certai lines
RomFloreani May 13, 2026
3825eec
Testing with safer github event
RomFloreani May 13, 2026
a55c7b7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 13, 2026
15f94f3
adding restriction of only branches that contain mirageo-ci --> so ei…
RomFloreani May 13, 2026
155e59c
Adding pre-commit-config guard as well
RomFloreani May 13, 2026
141b12d
Fixing the actions branch name pattern
RomFloreani May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions .github/workflows/reusable-jira-pr_actions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ permissions:

jobs:
get_issue_key:
if: ${{ github.event.pull_request.user.login != 'dependabot' && github.event.pullrequest.user.type != 'Bot' }}
runs-on: ubuntu-latest
timeout-minutes: 5
outputs:
Expand All @@ -39,6 +38,7 @@ jobs:
steps:
- name: Find JIRA issue key from branch
id: issue_key_from_branch
if: ${{ !startsWith(github.head_ref, 'dependabot/') && github.head_ref != 'pre-commit-ci-update-config' }}
env:
HEAD_REF: ${{ github.head_ref }}
run: >
Expand Down Expand Up @@ -80,9 +80,22 @@ jobs:

echo "issue_key=$issue_key" >> $GITHUB_OUTPUT

- name: Fail if no Jira key and not expected bot PR
if: ${{ !steps.issue_key.outputs.issue_key &&
!(github.event.sender.login == 'dependabot[bot]' && startsWith(github.head_ref, 'dependabot/github-actions/') && contains(github.head_ref, '/mirageo-ci-tools') && startsWith(github.event.pull_request.title, 'Bump ')) &&
!(github.event.sender.login == 'pre-commit-ci[bot]' && github.head_ref == 'pre-commit-ci-update-config') }}
run: |
echo "::error::No Jira issue key found. Please include one in your PR title (e.g. ABC-123: your title)"
exit 1


add_jira_summary:
if: ${{ github.event.action == 'opened' }}
if: ${{ needs.get_issue_key.result == 'success' &&
!startsWith(github.event.pull_request.body, format('**{0}', needs.get_issue_key.outputs.issue_key)) &&
(github.event.action == 'opened' ||
(github.event.action == 'synchronize' &&
github.event.pull_request.user.type == 'Bot' &&
github.event.sender.type == 'User')) }}
runs-on: ubuntu-latest
timeout-minutes: 20
needs: get_issue_key
Expand Down Expand Up @@ -128,6 +141,7 @@ jobs:
> /dev/null

check_jira_issue:
if: ${{ needs.get_issue_key.result == 'success' }}
runs-on: ubuntu-latest
timeout-minutes: 20
needs: get_issue_key
Expand Down
Loading