Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 80 additions & 7 deletions src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
import { BrowserRouter, Routes, Route, Navigate, useParams } from 'react-router-dom'
import { useAuthStore } from './store/auth'
import { useFeatureStore } from './store/feature'
import {
firstManagerPath,
hasManagerCapability,
type ManagerCapabilityKey,
} from './auth/capabilities'
import MainLayout from './layouts/MainLayout'
import AdminThemeProvider from './layouts/AdminThemeProvider'
import Login from './pages/Login'
Expand All @@ -24,6 +29,25 @@ function SuperOnlyRoute({ children }: { children: React.ReactNode }) {
return <>{children}</>
}

function CapabilityRoute({
capability,
children,
}: {
capability: ManagerCapabilityKey
children: React.ReactNode
}) {
const { managerCapabilities, managerProfileStatus } = useAuthStore()
if (
managerProfileStatus === 'idle' ||
managerProfileStatus === 'loading' ||
managerCapabilities === null
) return null
if (!hasManagerCapability(managerCapabilities, capability)) {
return <Navigate to={firstManagerPath(managerCapabilities)} replace />
}
return <>{children}</>
}

function SpaceOnlyRoute({ children }: { children: React.ReactNode }) {
const { isLoggedIn, scope } = useAuthStore()
if (!isLoggedIn || scope !== 'space') return <Navigate to="/space" replace />
Expand Down Expand Up @@ -108,13 +132,62 @@ function AdminRoutes() {
}
>
<Route index element={<Navigate to="/dashboard" replace />} />
<Route path="dashboard" element={<Dashboard />} />
<Route path="users" element={<Users />} />
<Route path="groups" element={<Groups />} />
<Route path="spaces" element={<Spaces />} />
<Route path="system-setting" element={<SystemSetting />} />
<Route path="backup" element={<Backup />} />
<Route path="download" element={<Download />} />
<Route
path="dashboard"
element={
<CapabilityRoute capability="dashboard.read">
<Dashboard />
</CapabilityRoute>
}
/>
<Route
path="users"
element={
<CapabilityRoute capability="users.read">
<Users />
</CapabilityRoute>
}
/>
<Route
path="groups"
element={
<CapabilityRoute capability="groups.read">
<Groups />
</CapabilityRoute>
}
/>
<Route
path="spaces"
element={
<CapabilityRoute capability="space.read">
<Spaces />
</CapabilityRoute>
}
/>
<Route
path="system-setting"
element={
<CapabilityRoute capability="system_setting">
<SystemSetting />
</CapabilityRoute>
}
/>
<Route
path="backup"
element={
<CapabilityRoute capability="backup">
<Backup />
</CapabilityRoute>
}
/>
<Route
path="download"
element={
<CapabilityRoute capability="appversion.read">
<Download />
</CapabilityRoute>
}
/>
<Route
path="app-bots"
element={
Expand Down
7 changes: 7 additions & 0 deletions src/api/auth.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import api from './index'
import { normalizeManagerCapabilities, type ManagerMe } from '../auth/capabilities'

interface LoginParams {
username: string
Expand All @@ -13,3 +14,9 @@ interface LoginResponse {

export const login = (params: LoginParams) =>
api.post<LoginResponse>('/v1/manager/login', params).then((res) => res.data)

export const getManagerMe = () =>
api.get<ManagerMe>('/v1/manager/me').then((res) => ({
...res.data,
capabilities: normalizeManagerCapabilities(res.data.capabilities),
}))
38 changes: 38 additions & 0 deletions src/auth/capabilities.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
import { describe, expect, it } from 'vitest'
import {
firstManagerPath,
hasManagerCapability,
normalizeManagerCapabilities,
} from './capabilities'

describe('manager capabilities', () => {
it('normalizes missing capability keys to false', () => {
const capabilities = normalizeManagerCapabilities({
'dashboard.read': true,
system_setting: false,
})

expect(capabilities['dashboard.read']).toBe(true)
expect(capabilities.system_setting).toBe(false)
expect(capabilities.backup).toBe(false)
})

it('checks capabilities strictly', () => {
const capabilities = normalizeManagerCapabilities({
'dashboard.read': 1,
system_setting: true,
})

expect(hasManagerCapability(capabilities, 'dashboard.read')).toBe(false)
expect(hasManagerCapability(capabilities, 'system_setting')).toBe(true)
})

it('selects the first readable manager path', () => {
const capabilities = normalizeManagerCapabilities({
'space.read': true,
'appversion.read': true,
})

expect(firstManagerPath(capabilities)).toBe('/spaces')
})
})
54 changes: 54 additions & 0 deletions src/auth/capabilities.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
export const MANAGER_CAPABILITY_KEYS = [
'system_setting',
'backup',
'appversion.read',
'appversion.write',
'dashboard.read',
'dashboard.trigger',
'users.read',
'users.write',
'users.manage_admin',
'groups.read',
'groups.write',
'space.read',
'space.write',
'space.destructive',
] as const

export type ManagerCapabilityKey = (typeof MANAGER_CAPABILITY_KEYS)[number]

export type ManagerCapabilities = Record<ManagerCapabilityKey, boolean>

export interface ManagerMe {
uid: string
name: string
role: string
capabilities: ManagerCapabilities
}

export function normalizeManagerCapabilities(
capabilities?: Partial<Record<ManagerCapabilityKey, unknown>> | null,
): ManagerCapabilities {
return MANAGER_CAPABILITY_KEYS.reduce((acc, key) => {
acc[key] = capabilities?.[key] === true
return acc
}, {} as ManagerCapabilities)
}

export function hasManagerCapability(
capabilities: ManagerCapabilities | null | undefined,
key: ManagerCapabilityKey,
): boolean {
return capabilities?.[key] === true
}

export function firstManagerPath(capabilities: ManagerCapabilities | null | undefined): string {
if (hasManagerCapability(capabilities, 'dashboard.read')) return '/dashboard'
if (hasManagerCapability(capabilities, 'users.read')) return '/users'
if (hasManagerCapability(capabilities, 'groups.read')) return '/groups'
if (hasManagerCapability(capabilities, 'space.read')) return '/spaces'
if (hasManagerCapability(capabilities, 'system_setting')) return '/system-setting'
if (hasManagerCapability(capabilities, 'backup')) return '/backup'
if (hasManagerCapability(capabilities, 'appversion.read')) return '/download'
return '/dashboard'
}
24 changes: 17 additions & 7 deletions src/hooks/useSpaceScope.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { useMemo } from 'react'
import { useAuthStore } from '../store/auth'
import { hasManagerCapability, type ManagerCapabilities } from '../auth/capabilities'
import * as manager from '../api/space'
import * as user from '../api/space-user'

Expand Down Expand Up @@ -78,6 +79,8 @@ export interface SpaceScope {
canManageInvites: boolean
canRemoveMembers: boolean
canAddMembers: boolean
canChangeMemberRoles: boolean
canUpdateSpaceProfile: boolean
canReviewApplies: boolean
supportsMemberSearch: boolean
supportsMemberPagination: boolean
Expand Down Expand Up @@ -107,14 +110,18 @@ export interface SpaceScope {
}
}

function buildSuperScope(): SpaceScope {
function buildSuperScope(capabilities: ManagerCapabilities | null): SpaceScope {
const canWrite = hasManagerCapability(capabilities, 'space.write')
const canDestructive = hasManagerCapability(capabilities, 'space.destructive')
return {
kind: 'super',
role: 'super',
canManageInvites: true,
canRemoveMembers: true,
canAddMembers: true,
canReviewApplies: true,
canManageInvites: canWrite,
canRemoveMembers: canDestructive,
canAddMembers: canWrite,
canChangeMemberRoles: canDestructive,
canUpdateSpaceProfile: canWrite,
canReviewApplies: canWrite,
supportsMemberSearch: true,
supportsMemberPagination: true,
supportsApplyFilter: true,
Expand Down Expand Up @@ -165,6 +172,8 @@ function buildUserScope(role: SpaceMemberRole): SpaceScope {
canManageInvites: isManager,
canRemoveMembers: isManager,
canAddMembers: false,
canChangeMemberRoles: role === 2,
canUpdateSpaceProfile: isManager,
canReviewApplies: isManager,
supportsMemberSearch: false,
supportsMemberPagination: true,
Expand Down Expand Up @@ -238,8 +247,9 @@ function buildUserScope(role: SpaceMemberRole): SpaceScope {

export function useSpaceScope(role?: SpaceMemberRole): SpaceScope {
const scope = useAuthStore((s) => s.scope)
const capabilities = useAuthStore((s) => s.managerCapabilities)
return useMemo(() => {
if (scope === 'super') return buildSuperScope()
if (scope === 'super') return buildSuperScope(capabilities)
return buildUserScope(role ?? 0)
}, [scope, role])
}, [capabilities, scope, role])
}
4 changes: 3 additions & 1 deletion src/i18n/locales/en-US/layout.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@
"theme.tooltip": "Theme: {{name}}",
"theme.light": "Light",
"theme.dark": "Dark",
"theme.auto": "Auto"
"theme.auto": "Auto",
"managerProfile.loadFailed": "Failed to load manager permissions",
"managerProfile.retry": "Retry"
}
4 changes: 3 additions & 1 deletion src/i18n/locales/zh-CN/layout.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@
"theme.tooltip": "主题:{{name}}",
"theme.light": "浅色",
"theme.dark": "深色",
"theme.auto": "跟随系统"
"theme.auto": "跟随系统",
"managerProfile.loadFailed": "管理员权限加载失败",
"managerProfile.retry": "重试"
}
Loading
Loading