Skip to content

Explicitly set compression ratio on resulting jar files #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Trial97
Copy link

@Trial97 Trial97 commented May 6, 2025

This is a follow-up from the discussion in: #77 (comment)
@LexManos, hopefully, this is what you wanted.
In the installer, this is the only ZipOutputStream instance.
If this should not be done here but in a different repo, let me know. I will try to adjust, as I do not fully grasp what needs to be done.

@LexManos
Copy link
Member

LexManos commented May 7, 2025

No, this is not the correct place. If you notice the task that you're working on doesn't actually check hashes.
The issue has alrwsyf been fixed and thus modern versions are not effected.
The issue is OLD already existing installers
So you would need to update all old installers to use the new installer tools/renamers where this issue is fixed.
Lucky for you we've had to fix the installer a few times for a few reasons. So I have a the core of the process already written https://github.com/MinecraftForge/InstallerRewriter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants