Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS grid to schedule teasers #41

Merged
merged 9 commits into from
Feb 16, 2019

Conversation

Brian-Clement
Copy link
Contributor

@Brian-Clement Brian-Clement commented Feb 11, 2019

Description

The existing schedule in the style guide did not include any "imperfect" examples of data (i.e. missing speaker images, company logos), and as a result the text was not vertically aligned in cases of content mismatches:

image

To address this, this PR does the following:

  • Removes speaker photo and logo from one row to create a visual example of incomplete content
  • Introduces a basic CSS grid with some flex for .schedule__teaser content to align items and vertically center
  • Incidentally this also updates composer.json to resolve a JsonValidationException whereby the string "true" was throwing errors upon a composer install.

The output now looks like this:

Desktop

image

Mobile

image

@Brian-Clement Brian-Clement self-assigned this Feb 11, 2019
@Brian-Clement Brian-Clement merged commit d2475e6 into master Feb 16, 2019
@Brian-Clement Brian-Clement deleted the feature/schedule-updates-grid branch February 16, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant